Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sapper icon #3219

Closed
eriandev opened this issue Jun 14, 2020 · 7 comments · Fixed by #4866
Closed

Sapper icon #3219

eriandev opened this issue Jun 14, 2020 · 7 comments · Fixed by #4866
Assignees

Comments

@eriandev
Copy link

eriandev commented Jun 14, 2020

Name: Sapper
Website: https://sapper.svelte.dev/
Official resources for icon and color:

The same Svelte icon but with #159794 brand color

@eriandev eriandev added the new icon Issues or pull requests for adding a new icon label Jun 14, 2020
@NovaGL
Copy link
Contributor

NovaGL commented Jun 14, 2020

SVG is in the top of the main page. I suggest we just use the "S"
https://sapper.svelte.dev/sapper-logo-horizontal.svg

Alexa Rank 46,637

Color #159794

@PeterShaggyNoble
Copy link
Member

Hmm ... we have in the past (most recently with the various subsidiaries of JR group) shied away from adding duplicate icons that differ only in colour, at most.

While I can definitely see the need for them, I think we'd need to come up with a different solution than having multiple, identical SVG files. One possible way could be through the changes being proposed and discussed in #2260, which might allow us to have multiple JSON entries pointing to a single SVG file.

@PeterShaggyNoble PeterShaggyNoble added the in discussion There is an ongoing discussion that should be finished before we can continue label Jun 19, 2020
@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented Jun 22, 2020

@erianvc, to assist us in dealing with and resolving this request, could you provide us with some detail on your use case for it? Do you need to be able to differentiate between Svelte & Sapper or just have the Sapper colour made available?

@PeterShaggyNoble PeterShaggyNoble added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jun 23, 2020
@eriandev
Copy link
Author

Yes, it was to have the brand color available.
I think should be able to point to the same SVG but different color, because there are brands that use the same icon but with different flavors...

@PeterShaggyNoble PeterShaggyNoble added pending Issues that are pending because of e.g. a scheduled brand update and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed in discussion There is an ongoing discussion that should be finished before we can continue labels Jun 25, 2020
@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented Jun 25, 2020

Thanks for the feedback, @erianvc. I'm of the same opinion as you that we should have some means of including brands that use the same logo just with different colours, but without duplication of the SVG. I've slapped the "pending" label on this until #2260 is resolved (we're aiming to have it done for the v3 release, Sunday week) and we see if we can leverage what we're doing there to address this.

@PeterShaggyNoble
Copy link
Member

Discussion on a possible approach for this has been moved to #3270.

@PeterShaggyNoble PeterShaggyNoble added good first issue Issues we believe are simple and a good first stab at contributing to the project and removed pending Issues that are pending because of e.g. a scheduled brand update labels Jul 10, 2020
@PeterShaggyNoble
Copy link
Member

Thanks for your patience, @erianvc; current consensus from #3270 for this is that we're going to allow SVGs with duplicate paths so would you like to have a read through our contributing guidelines and give this a try yourself?

Note that our existing Svelte icon will need to be updated first (see #3169) before it can be copied for Sapper.

@PeterShaggyNoble PeterShaggyNoble self-assigned this Jan 26, 2021
@ericcornelissen ericcornelissen mentioned this issue Feb 3, 2021
7 tasks
@PeterShaggyNoble PeterShaggyNoble added icon data and removed good first issue Issues we believe are simple and a good first stab at contributing to the project new icon Issues or pull requests for adding a new icon labels Mar 8, 2021
@PeterShaggyNoble PeterShaggyNoble added the pending Issues that are pending because of e.g. a scheduled brand update label Mar 15, 2021
@service-paradis service-paradis removed the pending Issues that are pending because of e.g. a scheduled brand update label May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants