New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sapper icon #3219
Comments
SVG is in the top of the main page. I suggest we just use the "S" Alexa Rank 46,637 Color |
Hmm ... we have in the past (most recently with the various subsidiaries of JR group) shied away from adding duplicate icons that differ only in colour, at most. While I can definitely see the need for them, I think we'd need to come up with a different solution than having multiple, identical SVG files. One possible way could be through the changes being proposed and discussed in #2260, which might allow us to have multiple JSON entries pointing to a single SVG file. |
@erianvc, to assist us in dealing with and resolving this request, could you provide us with some detail on your use case for it? Do you need to be able to differentiate between Svelte & Sapper or just have the Sapper colour made available? |
Yes, it was to have the brand color available. |
Thanks for the feedback, @erianvc. I'm of the same opinion as you that we should have some means of including brands that use the same logo just with different colours, but without duplication of the SVG. I've slapped the "pending" label on this until #2260 is resolved (we're aiming to have it done for the v3 release, Sunday week) and we see if we can leverage what we're doing there to address this. |
Discussion on a possible approach for this has been moved to #3270. |
Thanks for your patience, @erianvc; current consensus from #3270 for this is that we're going to allow SVGs with duplicate paths so would you like to have a read through our contributing guidelines and give this a try yourself? Note that our existing Svelte icon will need to be updated first (see #3169) before it can be copied for Sapper. |
Name: Sapper
Website: https://sapper.svelte.dev/
Official resources for icon and color:
The same Svelte icon but with
#159794
brand colorThe text was updated successfully, but these errors were encountered: