Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct GitLab icon #3621

Merged
merged 2 commits into from Oct 2, 2020
Merged

Conversation

service-paradis
Copy link
Member

image

Issue: #3169
Alexa rank:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering why the new svg became so much larger than the old one.
On opening I found a lot of superfluous points – on the straight lines and especially a mess in the most bottom rounding.
How were they introduced?
I sadly can't accept this PR until the file is cleaned up.

@service-paradis
Copy link
Member Author

Oh, you're right, sorry about that!
I started again from scratch, used Inkscape to resize and to clean some lines. Like before, used https://jakearchibald.github.io/svgomg/ to optimize.
Hope it is better this time!

Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that looks clean. Thank you so much for your work! 💯

@runxel runxel changed the title Update GitLab icon Correct GitLab icon Oct 2, 2020
@runxel runxel merged commit 473b41f into simple-icons:develop Oct 2, 2020
@runxel runxel added update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both and removed changes requested labels Oct 2, 2020
@service-paradis
Copy link
Member Author

Great! Glad you like it :)

github-actions bot added a commit that referenced this pull request Oct 4, 2020
# New Icons

- Arlo (#3202)
- Azure Data Explorer (#3189)
- Bata (#3077)
- bunq (#3194)
- Cloud 66 (#3371)
- Clubhouse (#3530)
- CurseForge (#3533)
- Daimler (#3151)
- FastAPI (#3522)
- G2A (#3042)
- HCL (#3060)
- Instructables (#3009)
- Julia (#3498)
- Kahoot (#3611)
- Kakao (#3192)
- Minecraft (#3026)
- PicPay (#3206)
- RenovateBot (#3486)
- Revolut (#3242)
- Ring (#3196)
- San Francisco Municipal Railway (#3118)
- Sketchfab (#3459)
- The Sounds Resource (#3603)
- Thumbtack (#3233)
- Tor Browser (#3452)
- Unilever (#3499)
- vFairs (#3365)
- VirtualBox (#3608)
- Wagtail (#3208)
- WakaTime (#2975)

# Updated Icons

- Amazon (#3619)
- Archicad (#3327)
- Firebase (#3620)
- Firefox Browser (#3622)
- Flutter (#3627)
- GitLab (#3621)
- HubSpot (#3625)
service-paradis added a commit to service-paradis/simple-icons that referenced this pull request Nov 11, 2020
The Great 2020 Icon Review
@service-paradis service-paradis deleted the gitlab-review branch November 17, 2020 13:42
service-paradis added a commit to service-paradis/simple-icons that referenced this pull request Nov 18, 2020
The Great 2020 Icon Review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants