Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BMW logo #2111

Closed
wants to merge 3 commits into from
Closed

Add BMW logo #2111

wants to merge 3 commits into from

Conversation

el1f
Copy link
Contributor

@el1f el1f commented Dec 10, 2019

Issue: #2059

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Toke the logo from the Wikipedia page for BMW (which is the same used by Wikimedia and by BMW itself, even if in form of a PNG on their website).
I went for the traditional BMW blue for the color and I've taken it from their logo.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Dec 13, 2019
@PeterShaggyNoble
Copy link
Member

After a bit of digging, I found an official EPS here, if you want to compare it to your file.

I also found this file, which includes details on 2 options for the monochrome logo as well as some Pantone refs. for their colours.

@PeterShaggyNoble PeterShaggyNoble changed the title ➕ BMW logo Add BMW logo Dec 17, 2019
@birjj
Copy link
Contributor

birjj commented Dec 20, 2019

Based on the files linked by @PeterShaggyNoble, I think I would expect either the black-on-light version, which has an extra ring outside of the "BMW" ring, or (preferably) the white-on-dark version which doesn't require much interpretation.

Unfortunately I couldn't find a vector version (the ones linked by @PeterShaggyNoble are for the BMW Clubs), but a reference logo can be seen in the photos attached to this press release (and related articles from other news outlets)

image

Could you update to a monochromization that matches @el1f?

@el1f
Copy link
Contributor Author

el1f commented Dec 20, 2019

Is it just me or is the "BMW" lettering different in every single incarnation of the logo?
Here is the latest update. Lettering ripped from the PDF linked by @PeterShaggyNoble, shapes traced based on the bitmap by @birjolaxew

simple-icons

Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long time no see 😅

I have to do some nitpicking here: If you look closely you will realize that the letters not "centered": the margin at the bottom to the inner ring is much smaller than to the outer ring.
That is not the case with the version Peter had linked. Maybe you can correct this :)

@ericcornelissen ericcornelissen added the abandoned Pull requests that have been abandoned by the contributor label Feb 18, 2020
@ericcornelissen
Copy link
Contributor

Closing this as work seems to have stopped. If you want to continue working on this @el1f feel free to re-open! 😄

And to anyone else, feel free to use this PR as a resource when adding the BMW logo.

@runxel runxel mentioned this pull request Feb 19, 2020
3 tasks
@el1f
Copy link
Contributor Author

el1f commented Feb 20, 2020

Sorry for the disappearance guys. Been busy working on some other projects and had little time to open any design tools :)
Seems like @runxel already took up the task so I'll leave the rest to him.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned Pull requests that have been abandoned by the contributor new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants