Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated TuneIn #3942

Merged
merged 2 commits into from Dec 4, 2020
Merged

Conversation

fbernhart
Copy link
Contributor

tunein

Issue: #3169
Alexa rank: -

Checklist

  • I updated the JSON data in _data/simple-icons.json --> (wasn't necessary)
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I took the already used SVG.
I used Inkscape to fix size and center
I used https://jakearchibald.github.io/svgomg/ to optimize the resulting SVG

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Nov 18, 2020
@service-paradis
Copy link
Member

service-paradis commented Dec 1, 2020

Hello @fbernhart
I think they might have updated their logo since I'm not able to find this one on their website. Looks like they now uses full words TUNE IN. Maybe I'm missing something. What do you think?

Edit: They use as a favicon

@fbernhart
Copy link
Contributor Author

fbernhart commented Dec 1, 2020

@service-paradis

I would go for the logo with the full word mark then.

Seems like it's used more often than the old one in the favicon.

If I visit their website on my phone, I can see the new logo in the header, the side menu and as advertisement for their app.

Screenshot_20201202-003628_Chrome.jpg

I would as well go for that kind of turquoise (in the logo) as color.

Do you agree?

@service-paradis
Copy link
Member

I think I would use the full wordmark logo as well. There are 2 primary color used in their website #14D8CC and #1C203C. I agree with you for the turquoise color. Maybe we can ask another @simple-icons/maintainers their opinion?

@mondeja
Copy link
Member

mondeja commented Dec 2, 2020

I also agree with #14D8CC

@NovaGL
Copy link
Contributor

NovaGL commented Dec 2, 2020

Hmm. I think there is already a PR for this.

How is this different to this #3115

@service-paradis
Copy link
Member

service-paradis commented Dec 2, 2020

Hmm. I think there is already a PR for this.
How is this different to this #3115

According to #3169, we're updating every icons that do not satisfy the guidelines. For example, the current icon for tunein is not centered
image

While reviewing, we also check if we need to update those icons. This looks to be the case here for the logo and the color.

@NovaGL
Copy link
Contributor

NovaGL commented Dec 2, 2020

Thanks for that. Maybe we should add a tag or something if it's just a positioning change not logo change.

The logo and colour is the same so why are you changing it?

@service-paradis
Copy link
Member

service-paradis commented Dec 2, 2020

The logo and colour is the same so why are you changing it?

Look like they always use full wordmark as their logo. The only place where I see the initials is in the favicon.
You're right about the color. My mistake!
Maybe I'm missing something? Is there some official sources I'm not aware of? Maybe we can keep it this way and only recenter it!

@NovaGL
Copy link
Contributor

NovaGL commented Dec 2, 2020

The favicion and sonos app uses it. I don't feel we should change the logo for the sake of it. This change seems over zealous.

I suggest just recentre it and we can decide later if we want the full wordmark in a future PR

@ericcornelissen
Copy link
Contributor

ericcornelissen commented Dec 2, 2020

I agree with @NovaGL that this PR can be merged as is since it fixes the centering of the existing icon.

That said, I have no strong opinions on whether we should switch to the full wordmark. Them using it for favicons is an indication that they prefer it for small sizes (and 12x12 is pretty small) (not sure about the size of icons in the Sonos app). But on the other hand, if many users don't instantly recognize this version then arguably we should switch to the more recognizable full wordmark.

So, we can also update to the full wordmark here if @fbernhart is open to doing that and if most @simple-icons/maintainers agree, currently it seems 2 are in favor of updating, 1 is indifferent, and 1 is against. Otherwise I think we should open an issue for TuneIn to discuss this further (or at least keep it in mind).

@fbernhart
Copy link
Contributor Author

I wouldn't mind working on a new logo (the full wordmark). Just let me know what the majority wants. 😊

@NovaGL
Copy link
Contributor

NovaGL commented Dec 2, 2020

I use this logo for projects that require a small logo eg L for logitech and N for Netflix. I would suggest we have two varients of these logos if we want to set a precedent with this logo

@ericcornelissen
Copy link
Contributor

ericcornelissen commented Dec 4, 2020

I use this logo for projects that require a small logo eg L for logitech and N for Netflix. I would suggest we have two varients of these logos if we want to set a precedent with this logo

Simple icons provides "Free SVG icons for popular brands", we are not aiming for good UI elements. If the brand forces us to use something that doesn't look good at small sizes that is the brands problem not ours.

That said, as long as TuneIn is still using the "LN" version of the logo, it seems to me we should use that since it works better at small sizes (where they use it as well). Thoughts on this @mondeja, @service-paradis, @fbernhart?

@ericcornelissen ericcornelissen added the in discussion There is an ongoing discussion that should be finished before we can continue label Dec 4, 2020
@mondeja
Copy link
Member

mondeja commented Dec 4, 2020

I'm not very familiar with this brand and do not really understand the discussion raised here, although from what I can understand I would be in favor of @ericcornelissen in using the "LN" version.

@service-paradis
Copy link
Member

They dont use the small logo a lot, but they still uses it. So lets keep this simple for now!

@fbernhart
Copy link
Contributor Author

What's the "LN version"? Are we talking about the letters "TI" like in the preview of my initial post?

I'm divided on this one.

They use the full wordmark on every part of their website (apart from the favicon) as well on Google's and Apple's app stores.

But they seem to use just the "TI" in all of their social media presence. Facebook, Instagram and Twitter. With around 770k followers in total, I would assume that people would as well recognise the brand with the "TI" logo.

So both versions seem to be frequently used by TuneIn.

@ericcornelissen
Copy link
Contributor

What's the "LN version"? Are we talking about the letters "TI" like in the preview of my initial post?

Ow wow, yes I meant the "TI" version 🙃


That sounds like some kind of a consensus to me, at least for now. We can always revisit this later and update the SVG if needed 🙂 At least now we don't need to ignore it in npm run svglint anymore. Thanks a bunch @fbernhart! 🎉

@ericcornelissen ericcornelissen removed the in discussion There is an ongoing discussion that should be finished before we can continue label Dec 4, 2020
@ericcornelissen ericcornelissen merged commit f3f226f into simple-icons:develop Dec 4, 2020
@fbernhart fbernhart deleted the Updated_TuneIn branch December 4, 2020 15:32
ericcornelissen added a commit that referenced this pull request Dec 6, 2020
# New Icons

- Couchbase (#3768)
- MYOB (#3398)
- Nubank (#3617)
- PhpStorm (#3372)
- TeamCity (#4207)
- TransferWise (#3637)
- Vonage (#3735)
- Wireshark (#4275)

# Updated Icons

- ABB RobotStudio (#3961)
- Azure DevOps (#3886)
- Brand.ai (#4002)
- Cash App (#3889)
- Clockify (#3890)
- Code Climate (#3892)
- Codecademy (#3891)
- CodeFactor (#3893)
- Dashlane (#3895)
- Disroot (#4024)
- Drupal (#4027)
- DTube (#3896)
- Feedly (#4047)
- Hypothesis (#3908)
- KeyCDN (#3911)
- Monzo (#3922)
- OpenID (#3924)
- OpenVPN (#3926)
- RunKit (#3933)
- Seagate (#3936)
- Sourcegraph (#3940)
- Stackbit (#4197)
- TUI (#4244)
- TuneIn (#3942)
- Vulkan (#4233)
- write.as (#3946)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants