Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Apache OpenOffice #3969

Merged
merged 6 commits into from Dec 10, 2020
Merged

Conversation

fbernhart
Copy link
Contributor

@fbernhart fbernhart commented Nov 19, 2020

apacheopenoffice

Issue: #3169
Alexa rank: -

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I've rebuilt the icon from https://apache.org/logos/
I used Inkscape to fix size and center
I used https://jakearchibald.github.io/svgomg/ to optimize the resulting SVG

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Nov 19, 2020
@fbernhart
Copy link
Contributor Author

fbernhart commented Dec 9, 2020

As the existing icon didn't pass the linter (even at a precision of 4), I've rebuilt it using the new source https://apache.org/logos/, as suggested in #2887.

If this get's merged, we can remove it from the list in #2887.

@mondeja mondeja mentioned this pull request Dec 10, 2020
17 tasks
@mondeja mondeja self-assigned this Dec 10, 2020
Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing a lot of more coordinates than necessary. See the next comparison between your version (red) and mine (blue). Have you used this SVG as source @fbernhart?

aoo-diff

@fbernhart
Copy link
Contributor Author

fbernhart commented Dec 10, 2020

@mondeja No, I used "Version 3", which is the logo alone. https://svn.apache.org/repos/asf/comdev/project-logos/originals/openoffice-2.svg

Seems like they used different SVGs to build the different versions.

@mondeja
Copy link
Member

mondeja commented Dec 10, 2020

I think that the source I've used it's more optimized, because I don't see differences in the geometries. Would you try again using that version?

@fbernhart
Copy link
Contributor Author

@mondeja I've found the reason. The SVGs are actually the same.

I've made a mistake in Inkscape. The "birds" are actually already cut out of the blue circle in the original SVG. But they still exist as extra path. So when I created the difference between the circle (with the birds already cut out) and the birds themselves, some more points were created.

I've solved it now by just deleting the extra birds path. 😄

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's perfect now ✨ Thank you @fbernhart!

@mondeja mondeja merged commit db31649 into simple-icons:develop Dec 10, 2020
@fbernhart fbernhart deleted the ApacheOpenOffice branch December 10, 2020 14:25
ericcornelissen added a commit that referenced this pull request Dec 13, 2020
# New Icons

- diagrams.net (#4310)
- Hack The Box (#4254)
- National Grid (#3633)
- Snowflake (#4089)
- Tutanota (#3375)

# Updated Icons

- Airbus (#3962)
- Anaconda (#3965)
- Apache (#4294, #3967)
- Apache OpenOffice (#3969)
- Audiomack (#3981)
- Bamboo (#3992)
- CRYENGINE (#3894)
- Eleventy (#3897)
- ESEA (#3898)
- Evernote (#3899)
- EyeEm (#3900)
- Google My Business (#3901)
- Gutenberg (#3904)
- HelloFresh (#3907)
- Humble Bundle (#4071)
- Livestream (#3913)
- McAfee (#4100)
- MicroStrategy (#4104)
- Minds (#4105)
- NEC (#4107)
- Nextdoor (#4110)
- NFC (#4111)
- Nim (#3923)
- NuGet (#4113)
- Platzi (#4169)
- Reason Studios (#4180)
- Salesforce (#4185)
- SketchUp (#4311)
- SlideShare (#3939)
- Steem (#4201)
- Steinberg (#4203)
- Stylus (#4215)
- Svelte (#4218)
- XFCE (#4241)
- YouTube Music (#4246)
- Zalando (#3947)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants