Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating guidelines unofficial source #6428

Merged
merged 19 commits into from
Sep 3, 2021
Merged
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ We welcome icon requests. Before you submit a new issue please make sure the ico
- For websites, the [Alexa rank](https://www.alexa.com/siteinfo) should be less than 500k.
- Note that for brands that have already been added the threshold for continued inclusion rises to 750k.
- For GitHub projects, the amount of "stars" should be above 5k.
- For a well known or widely accepted de facto standard logo (where official sources don't exist), popularity will be assesed on a case-by-case basis by maintainers. For example, Javascript falls in this category.
jorgeamadosoria marked this conversation as resolved.
Show resolved Hide resolved
jorgeamadosoria marked this conversation as resolved.
Show resolved Hide resolved
- For anything else, popularity will be judged on a case-by-case basis.
jorgeamadosoria marked this conversation as resolved.
Show resolved Hide resolved
* Doesn't fall into one of the following categories:
- Illegal service (e.g. piracy, malware, threatening material, spam etc.)
Expand Down Expand Up @@ -86,6 +87,9 @@ Official high quality brand logos and brand colors can usually be found in the f
1. Wikimedia (which should provide a source)
1. GitHub repositories

It may be the case that official sources simply do not exist, but an unofficial icon has gained widespread acceptance and popularity. These icons can also be included, after being reviewed and accepted by maintainers on a case-by-base basis. Javascript is the prime example of this situation.
jorgeamadosoria marked this conversation as resolved.
Show resolved Hide resolved
Notice that an unofficial icon won't replace or supersede an official one, even if it more popular. An unofficial icon will only be accepted if official options do not exist.
jorgeamadosoria marked this conversation as resolved.
Show resolved Hide resolved

#### Icon Guidelines

Working with an SVG version of the logo is best. In the absence of an SVG version, other vector filetypes may work as well (e.g. EPS, AI, PDF). In the absence of vector logos, a vector can be created from a high quality rasterized image, however this is much more labor intensive.
Expand Down