Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefer-string-starts-ends-with
: add suggestions for safely handling non-strings #1277prefer-string-starts-ends-with
: add suggestions for safely handling non-strings #1277Changes from 25 commits
458dfdb
cf560f6
1ce3ff3
5e2668b
f88404f
e9b16d8
accc866
285ee93
37f7af0
cb5e41d
1bb4725
4c6e14e
f29f8b3
52f3d66
216745a
c1e4502
c593626
e931884
9d8300e
4dcdbaf
37ae338
5f48586
4c80e5a
5ae4507
c8f72ca
3a3d055
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds extra parenthesis that aren't needed sometimes. I think I had code to handle this before.
in:
(/^b/).test((a))
out:
((a)).startsWith('b')
Not a big deal though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that, but better "add missing parens" instead of "remove extra parens".