Add optional team parameter to GetTeamInfo function calls

[ed-wp]

Solves: #980

Pull Request Guidelines

These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.

PR preparation

• Run make pr-prep from the root of the repository to run formatting, linting and tests.

Should this be an issue instead

• is it a convenience method? (no new functionality, streamlines some use case)
• exposes a previously private type, const, method, etc.
• is it application specific (caching, retry logic, rate limiting, etc)
• is it performance related.

API changes

Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.

• [no tests, if you're adding to the API include at least a single test of the happy case.
• If you can accomplish your goal without changing the API, then do so.
• dependency changes. updates are okay. adding/removing need justification.

Examples of API changes that do not meet guidelines:

• in library cache for users. caches are use case specific.
• Convenience methods for Sending Messages, update, post, ephemeral, etc. consider opening an issue instead.

[ShamanR]

sould we test emty team case?

[ShamanR]

Backward compatibility issue.

[kanata2]

I'm having trouble with only one optional parameter...
I've come up with a few ideas, which one do you think is better?

other idea 1

How about adding GetAnotherTeamInfo(team string) method .

// Get your own team information.
info, err := api.GetTeamInfo()

// Get other team information.
info, err := api.GetOtherTeamInfo(teamID)

other idea 2

Use functional option pattern.

// Get your own team information.
info, err := api.GetTeamInfo()

// Get other team information.
info, err := api.GetTeamInfo(slack.GetTeamInfoOptionTeamID(teamID))

[ed-wp]

I feel like even though this is not backwards compatible, it follows how the slack API actually operates and makes it less confusing.

From Slack API Docs:

Team to get info on, if omitted, will return information about the current team. Will only return team that the authenticated token is allowed to see through external shared channels

I think that other option 2 is closer to the APIs definition, but not nearly as close as my proposal.

Thoughts?

[kanata2]

I think that other option 2 is closer to the APIs definition, but not nearly as close as my proposal.

The parameter team is an optional in Slack while it is required in our GetTeamInfo API with your proposal, so I think it is not so good design.
The difference in idea 2 is that it keeps team parameter optional.

[kanata2]

#1118 is merged.