New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Handle ES2018 capture names #247
Merged
Merged
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
dff32fe
Update tests to show API changes
josephfrazier c324a75
Use RegExpIdentifierName without escape sequences for named captures/…
josephfrazier 1e000ef
Update build tools to make it actually work
josephfrazier 101d4c7
Remove now-unnecessary bare integer check from named capture group pa…
josephfrazier b489e50
Just say RegExpIdentifierName instead of listing alphnumeric/$_, see …
josephfrazier 50d95f9
Test operation of named capture groups, not just construction, see ht…
josephfrazier 35a63a6
Reference "RegExpIdentifierName characters" instead of listing the na…
josephfrazier c68536e
Don't disallow numbered backreferences like \k<1>, see https://github…
josephfrazier b20cadd
Restore tests of explicit numbered backreferences, see https://github…
josephfrazier 86318d4
Reallow explicit numbered backreferences in replacement text, see htt…
josephfrazier 574a5bb
Reallow numbered backreferences in patterns, see https://github.com/s…
josephfrazier 4eee345
Restore s-xregexp-methods.js
josephfrazier 6ff1615
Update code comments, see https://github.com/slevithan/xregexp/pull/2…
josephfrazier 6ecf26c
Merge branch 'master' into test-node-10
josephfrazier File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It allows the eslint parser to support the new syntax in src/xregexp.js, rather than showing an error like this: