use Babel instead of ts-jest to speed up and simplify tests #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqs
force-pushed
the
use-babel-for-ts-tests
branch
from
b177823
to
0e8c0c9
Compare
Merged
felixfbecker
approved these changes
May 13, 2019
sqs
force-pushed
the
use-babel-for-ts-tests
branch
2 times, most recently
from
f2dc1a5
to
2c593cb
Compare
|
I don't currently see compile errors from test files in VS Code (without explicitly opening the file). It seems like they are not checked by the |
sqs
force-pushed
the
use-babel-for-ts-tests
branch
from
2c593cb
to
ad50e4c
Compare
sqs
force-pushed
the
use-babel-for-ts-tests
branch
from
ad50e4c
to
0040acc
Compare
sqs
force-pushed
the
use-babel-for-ts-tests
branch
2 times, most recently
from
72ba85b
to
a8ef0cf
Compare
|
@felixfbecker given that @sqs is out on pat leave, is this something that should be merged, or should we close this? |
sqs
force-pushed
the
use-babel-for-ts-tests
branch
from
a8ef0cf
to
da87d7f
Compare
|
@beyang keep open pls This can be merged when @babel/plugin-transform-typescript 7.5.0 is released, which should be soon. That version will incorporate the fix in babel/babel#9610, which should solve the problem that causes CI to fail. |
|
@sqs 7.5.0 was just released :) |
|
@felixfbecker Re: vscode not showing errors from not-yet-opened files, I am indeed seeing that problem, but I am actually not seeing any of the tasks work: It doesn't seem to be related to this PR, so I'm not going to block this PR. |
sqs
force-pushed
the
use-babel-for-ts-tests
branch
2 times, most recently
from
15b17eb
to
6055ef0
Compare
Removed typechecking from jest tests (by removing ts-jest and just using Babel's TypeScript transpilation, per https://jestjs.io/docs/en/getting-started#using-typescript). This makes tests run faster (~2s vs. ~9s for a single test after making a change to a `.ts` file) and simplifies their build configuration (by removing an unnecessary tool, ts-jest, from our toolchain). You should instead rely on your editor (and CI) for typechecking. Babel is a good choice because it is the standard for transpilation, and tslint is being deprecated in favor of Babel + eslint (so we need to switch soon anyway to get the latest lint rules, such as those for React hooks).
sqs
force-pushed
the
use-babel-for-ts-tests
branch
from
6055ef0
to
f29106f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3959 +/- ##
==========================================
- Coverage 48.06% 46.44% -1.63%
==========================================
Files 733 730 -3
Lines 44817 44419 -398
Branches 1763 2610 +847
==========================================
- Hits 21541 20630 -911
- Misses 21300 21813 +513
Partials 1976 1976
|
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed typechecking from jest tests (by removing ts-jest and just using Babel's TypeScript transpilation, per https://jestjs.io/docs/en/getting-started#using-typescript). This makes tests run faster (~2s vs. ~9s for a single test after making a change to a
.tsfile) and simplifies their build configuration (by removing an unnecessary tool, ts-jest, from our toolchain). You should instead rely on your editor (and CI) for typechecking.Babel is a good choice because it is the standard for transpilation, and tslint is being deprecated in favor of Babel + eslint (so we need to switch soon anyway to get the latest lint rules, such as those for React hooks).