Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Babel instead of ts-jest to speed up and simplify tests #3959

Merged
merged 2 commits into from Jul 25, 2019
Merged

use Babel instead of ts-jest to speed up and simplify tests #3959

merged 2 commits into from Jul 25, 2019

Commits on Jul 25, 2019

  1. use Babel instead of ts-jest to speed up and simplify tests 

    Removed typechecking from jest tests (by removing ts-jest and just using Babel's TypeScript transpilation, per https://jestjs.io/docs/en/getting-started#using-typescript). This makes tests run faster (~2s vs. ~9s for a single test after making a change to a `.ts` file) and simplifies their build configuration (by removing an unnecessary tool, ts-jest, from our toolchain). You should instead rely on your editor (and CI) for typechecking.

Babel is a good choice because it is the standard for transpilation, and tslint is being deprecated in favor of Babel + eslint (so we need to switch soon anyway to get the latest lint rules, such as those for React hooks).
    @sqs
    sqs committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    80bd0d6 View commit details
    Browse the repository at this point in the history

  2. fix race condition

    @sqs
    sqs committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    f29106f View commit details
    Browse the repository at this point in the history