Fix tests #1245
Closed
Fix tests #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Dean <ben.dean@finvi.com>
Signed-off-by: Ben Dean <ben.dean@finvi.com>
Signed-off-by: Ben Dean <ben.dean@finvi.com>
Signed-off-by: Ben Dean <ben.dean@finvi.com>
b-dean
force-pushed
the
fix-tests
branch
2 times, most recently
from
a38b8a9
to
ef234ae
Compare
bmhughes
added
Bug
bmhughes
reviewed
May 21, 2023
bmhughes
requested changes
May 21, 2023
…ef workstation version Signed-off-by: Ben Dean <ben.dean@finvi.com>
Signed-off-by: Ben Dean <ben.dean@finvi.com>
…it times out Signed-off-by: Ben Dean <ben.dean@finvi.com>
|
Sorry about all the force pushes over and over. I was trying to keep the changes related to fixing tests in here so #1246 was just changing things for Chef 18. If you tag a new version of sous-chefs/.github I'll commit again here, otherwise it should be good. |
|
this was merged as part of #1246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were a number of tests failing because of Chef 17 vs 18 or Docker version 24. I'm working on fixing another issue and thought I'd just make a PR with these changes.
Issues Resolved
Depends on sous-chefs/.github#25 being merged first if you don't want to refer to my branch.
Check List
## Unreleased