New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chef 18 #1246
Merged
Merged
Chef 18 #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Dean <ben.dean@finvi.com>
Signed-off-by: Ben Dean <ben.dean@finvi.com>
Signed-off-by: Ben Dean <ben.dean@finvi.com>
Signed-off-by: Ben Dean <ben.dean@finvi.com>
…ef workstation version Signed-off-by: Ben Dean <ben.dean@finvi.com>
b-dean
force-pushed
the
chef-18
branch
3 times, most recently
from
May 23, 2023 19:30
a9ebee5
to
22b972d
Compare
Signed-off-by: Ben Dean <ben.dean@finvi.com>
…it times out Signed-off-by: Ben Dean <ben.dean@finvi.com>
not exactly a fix for sous-chefs#1222 Signed-off-by: Ben Dean <ben.dean@finvi.com>
The following resources are now custom resources: - `docker_installation` - `docker_installation_package` - `docker_installation_script` - `docker_installation_tarball` - `docker_service` - `docker_service_base` - `docker_service_manager` - `docker_service_manager_execute` - `docker_service_manager_systemd` This fixes sous-chefs#1222 so the docker cookbook will work with Chef 18 Signed-off-by: Ben Dean <ben.dean@finvi.com>
Can this be merged? |
bmhughes
approved these changes
May 29, 2023
bmhughes
added
the
Release: Major
Release to Chef Supermarket as a major change when merged
label
May 29, 2023
Released as: 11.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change remaining library class-based resources to into custom resources. Also fix the various
docker_installation
anddocker_service
resources to work in unified mode (which is on by default in Chef 18).Issues Resolved
#1222
This also includes the changes in #1245
Check List
## Unreleased