New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Windows setup script #673
Improve Windows setup script #673
Conversation
- Change LLVM install logic to use version 15 instead of the latest, due to incompatibilities of new LLVM (16) with `ffmpeg-sys-next` build script - Add check to ensure script is executed as administrator, due to chocolatey requiring admin privileges to install `protoc` - Update ffmpeg to 5.1.1 to match used `ffmpeg-sys-next` version - Don't attempt to reinstall LLVM when it is already installed
@HeavenVolkoff is attempting to deploy a commit to the Spacedrive Team on Vercel. A member of the Team first needs to authorize it. |
- Remove dependency in Chocolatey - Download ffmpeg version based on ffmpeg-sys-next version - Improve version checks - Install protobuf directly from github - Update rimraf so globbing works in Windows - Avoid dist/.gitignore being deleted by rimraf
- Check for connectivity with GitHub before proceeding with setup. - Implement a workaround for pnpm bootstrap problems on Windows. - Check if Cargo packages are up to date before parsing the metadata. - Ensure that the FFMPEG_DIR environment variable is set. - Use double quotes for rimraf arguments on Windows.
- Fix protoc envvars not being set in CI - Improve logs
- Remove sleeps - Uninstall any imcompatible LLVM version present - Ensure path is fresh after installing rust and cargo
- Install node with winget and pnpm with npm - Rewrite initial script message - Don't wait for user interaction when running in CI
- Warn users if they have already installed incompatible versions of LLVM and pnpm instead of silently removing them
…tup script - Improve error handling - Improve logs
- Fix some typos
So, I ended up rewriting the entire script. I'm sorry about that, but now it will bootstrap the entire development environment from scratch without the need for user intervention, as long as they have For the major changes I made to the original script, I replaced the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is huge as Windows has been the hardest platform for new developers to jump in with. Thank you!
Hello,
During testing of my QuickPreview implementation (PR #665) on Windows, I encountered some problems setting up the project. This PR addresses those issues by changing the Windows setup script to make it more robust, less redundant, and to fix recent problems caused by major updates to PNPM and LLVM that were breaking installation and compilation on Windows.
These changes include:
(required by Chocolatey)Installing Chocolatey if not availableUpdating ffmpeg version from 5.0.1 to 5.1.1