Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Windows setup script #673

Merged
merged 15 commits into from
Apr 10, 2023
Merged

Improve Windows setup script #673

merged 15 commits into from
Apr 10, 2023

Commits on Apr 4, 2023

  1. Improve Windows setup script

     - Change LLVM install logic to use version 15 instead of the latest, due to incompatibilities of new LLVM (16) with `ffmpeg-sys-next` build script
     - Add check to ensure script is executed as administrator, due to chocolatey requiring admin privileges to install `protoc`
     - Update ffmpeg to 5.1.1 to match used `ffmpeg-sys-next` version
     - Don't attempt to reinstall LLVM when it is already installed
    HeavenVolkoff committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    c7564a2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a2e12b1 View commit details
    Browse the repository at this point in the history
  3. Fix typo

    HeavenVolkoff committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    8b29d07 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ed0e85d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d463f4c View commit details
    Browse the repository at this point in the history
  6. More logs

    HeavenVolkoff committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    7af0fea View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b7760c8 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Better installation logic for llvm, protobuf, ffmpeg

     - Remove dependency in Chocolatey
     - Download ffmpeg version based on ffmpeg-sys-next version
     - Improve version checks
     - Install protobuf directly from github
     - Update rimraf so globbing works in Windows
     - Avoid dist/.gitignore being deleted by rimraf
    HeavenVolkoff committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    57b7800 View commit details
    Browse the repository at this point in the history
  2. Fix bugs and handle errors in Windows setup script

    - Check for connectivity with GitHub before proceeding with setup.
    - Implement a workaround for pnpm bootstrap problems on Windows.
    - Check if Cargo packages are up to date before parsing the metadata.
    - Ensure that the FFMPEG_DIR environment variable is set.
    - Use double quotes for rimraf arguments on Windows.
    HeavenVolkoff committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    e2a802d View commit details
    Browse the repository at this point in the history
  3. Auto-install VisualBuildTools (C++) and Rust in Windows setup

     - Fix protoc envvars not being set in CI
     - Improve logs
    HeavenVolkoff committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    97eccab View commit details
    Browse the repository at this point in the history
  4. Install LLVM automatically

     - Remove sleeps
     - Uninstall any imcompatible LLVM version present
     - Ensure path is fresh after installing rust and cargo
    HeavenVolkoff committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    6f4c678 View commit details
    Browse the repository at this point in the history
  5. Fix system path not being set correctly in windows setup script

     - Install node with winget and pnpm with npm
     - Rewrite initial script message
     - Don't wait for user interaction when running in CI
    HeavenVolkoff committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    82a65a3 View commit details
    Browse the repository at this point in the history
  6. Improve environment check to ensure we are on Windows x64

     - Warn users if they have already installed incompatible versions of LLVM and pnpm instead of silently removing them
    HeavenVolkoff committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    be4206e View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Ensure Path and Env are correctly set and available in the windows se…

    …tup script
    
     - Improve error handling
     - Improve logs
    HeavenVolkoff committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    12e19c5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    24794ad View commit details
    Browse the repository at this point in the history