Replace pkg_resources with importlib.metadata #10007
Conversation
|
The mypy failure appears to be unrelated. Mypy 0.930 was just released today, and if I use this on the 4.x branch, it fails. Mypy 0.921 passes on both branches. I can limit the version range used in |
|
Now I just fixed the warnings from mypy on the HEAD of 4.x branch now. Could you merge it to your branch, please? Then CI will go fine. |
|
Merged 4.x into this branch, and the CI is indeed OK again. 🙂 |
|
Thank you for your contribution. Merged! |
| try: # Python < 3.10 (backport) | ||
| from importlib_metadata import entry_points | ||
| except ImportError: | ||
| from importlib.metadata import entry_points |
There was a problem hiding this comment.
Is there a reason the builtin isn't tried before the backport?
There was a problem hiding this comment.
Yes: the code is using APIs that were changed in 3.10, so for 3.8 and 3.9 we want to use the backport over the standard library module. 🙂
Feature or Bugfix
Purpose
As discussed in #9595,
importlib.metadatais the modern way to find entry points, replacingpkg_resources. It's in the standard library from 3.8, but part of the API I've used is new in 3.10, so theimportlib_metadatabackport is used on older versions.Concretely,
pkg_resourcesscans metadata from all packages at import time, which is generally considered a bad thing.importlib.metadataonly scans metadata when it's called.