ImageConverter: ignore '?' image URIs #10118
Merged
+2
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #10073 has fixed my minimal example, it wasn't enough to fix my original problem spatialaudio/nbsphinx#559.
It turns out that on top of
data:
URIs, remote URIs have also been automatically handled as "not supported" and therefore unnecessarily invoked the image converters.This PR ignores all
'?'
images, which includesdata:
URIs, therefore I've reverted the changes from #10099, which are no longer necessary.I still don't know what
'?'
means exactly, it would probably be nice to add a comment explaining what that is and why it's ignored.Example project for experiments: https://github.com/mgeier/rsvgconverter-bug