URI-escape image filenames #10268
Merged
URI-escape image filenames #10268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, local images with `#` in their name result in incorrect URLs There is already a similar call to `urllib.parse.quote` for file downloads, suggesting this is a sensible approach.
tk0miya
requested changes
Mar 16, 2022
|
#9670 didn't have a test-case, so I was hoping I could get away without one here too... I might have time for a test-case in a week or so, we'll see. |
|
It seems #9670 contains a test-case :-) |
|
Hmm... epubcheck and LaTeX build are failed when we use |
|
It sounds like the latex code needs escaping too |
|
Thanks for fixing the broken tests! |
|
Is there any way to see the latex error message from CI? |
|
I think the CI failure is actually a bug in |
AA-Turner
reviewed
Oct 5, 2022
|
@eric-wieser it looks like the test failures are pretty simple to solve--are you up for having a look, it would be nice to get this in to 5.3. A |
AA-Turner
reviewed
Oct 13, 2022
|
Thanks @eric-wieser! A |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, local images with
#in their name result in incorrect URLs in HTML builds.There is already a similar call to
urllib.parse.quotefor file downloads, added in #9670, suggesting this is a sensible approach.This also adds a hack to make things work for
#specifically in LaTeX, but more work is likely needed for other weird character there.Feature or Bugfix