Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #10200: apidoc: Duplicated submodules are shown for modules #10402

Closed
wants to merge 1 commit into from
Closed

Fix #10200: apidoc: Duplicated submodules are shown for modules #10402

wants to merge 1 commit into from

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Apr 30, 2022

@tk0miya tk0miya added this to the 5.0.0 milestone Apr 30, 2022
@AA-Turner
Copy link
Member

Is it possible to add a test for this?

A

@tk0miya
Copy link
Member Author

tk0miya commented Apr 30, 2022

I don't have knowleged about cpython. So it's difficult to me. Could you help me?

@AA-Turner
Copy link
Member

Commit bde47ce on my branch (https://github.com/AA-Turner/sphinx/tree/apidoc-duplicates) contains a basic test that could be cherrypicked into this branch.

A

@tk0miya
Copy link
Member Author

tk0miya commented May 1, 2022

Ah, I understand. Indeed, No knowledge of cython is needed to test this. Could you post your fix as a new PR, please? Then I'll merge it instead.

@tk0miya tk0miya closed this May 1, 2022
@tk0miya tk0miya deleted the 10200_apidoc_remove_duplicated_submodules branch May 1, 2022 06:16
@AA-Turner AA-Turner mentioned this pull request May 1, 2022
Merged
@AA-Turner
Copy link
Member

Done, please see #10406

A

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
extensions:apidoc type:bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tk0miya @AA-Turner