Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure submodules are unique in sphinx.ext.apidoc #10406

Merged
merged 2 commits into from May 1, 2022

Conversation

AA-Turner
Copy link
Member

Follows on from #10402
Closes #10200

A

Feature or Bugfix

  • Bugfix

@AA-Turner
Copy link
Member Author

By the way @tk0miya, do you know if there is a process for granting triage permissions / etc? That way I would be able to apply labels and milestones to these PRs (and others) myself -- it saves you some work!

A

Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work!

@tk0miya tk0miya added this to the 5.0.0 milestone May 1, 2022
@tk0miya tk0miya merged commit 2f29f0a into sphinx-doc:5.x May 1, 2022
@AA-Turner AA-Turner deleted the apidoc-duplicates branch May 1, 2022 10:03
@tk0miya
Copy link
Member

tk0miya commented May 1, 2022

By the way @tk0miya, do you know if there is a process for granting triage permissions / etc?

Thank you for your proposal. It must be helpful for us. Unfortunately, we don't have a proper rule to add maintainers and contributors. But I sometimes posted issues on inviting new maintainers so far: https://github.com/sphinx-doc/sphinx/issues?q=is%3Aissue+invite+new+maintainer.

@AA-Turner
Copy link
Member Author

Thanks for the context @tk0miya -- I'm one of the current PEP editors for Python so I've got somewhat of an interest in making sure Sphinx works & we've spoken on the Docutils tracker too, so very happy to help out as a maintainer if you'd like -- equally no worries if there are enough team members currently!

Thanks for your help reviewing my PRs, it is great to help out.

A

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apidoc: Double entries for cython modules (both .pyx and .so found)
2 participants