New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dependencies): upgrade snakeyaml from 1.29 to 1.31 #1173

Merged

mergify merged 1 commit into spinnaker:master from j-sandy:snakeyaml-unpin

Mar 21, 2024

Commits on Mar 21, 2024

chore(dependencies): upgrade snakeyaml from 1.29 to 1.31

Spring boot 2.6.15 brings in snakeyaml 1.29, which [fails to parse
yaml](spring-projects/spring-boot#30159 (comment))
(including some k8s manifests).  It's safe to upgrade beyond 1.29 according to
[this](spring-projects/spring-boot#32228 (comment)). However,
snakeyaml 1.32 has a
[feature](https://bitbucket.org/snakeyaml/snakeyaml/issues/547/restrict-the-size-of-incoming-data)
to restrict the size of incoming data to 3 MB by default
([PR](https://bitbucket.org/snakeyaml/snakeyaml/pull-requests/22)), and spring boot
versions <= 3.0.7 are not equipped to modify this.  So, use 1.31 in order to avoid the
limit till upgrade >= 3.0.7 and to resolve CVE-2022-25857 and CVE-2022-38749.

before:

|    |    +--- org.yaml:snakeyaml:1.29 -> 1.27 (c)
|    +--- org.yaml:snakeyaml:{strictly 1.27} -> 1.27 (c)

after:

|    |    +--- org.yaml:snakeyaml:1.29 -> 1.31 (c)
|    +--- org.yaml:snakeyaml:1.31 (c)

j-sandy authored and dbyron-sf committed Mar 21, 2024