chore(dependencies): upgrade snakeyaml from 1.29 to 1.31 #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
force-pushed
the
snakeyaml-unpin
branch
from
4afb107
to
15e195b
Compare
dbyron-sf
changed the title
dbyron-sf
force-pushed
the
snakeyaml-unpin
branch
from
15e195b
to
1a233c7
Compare
Spring boot 2.6.15 brings in snakeyaml 1.29, which [fails to parse yaml](spring-projects/spring-boot#30159 (comment)) (including some k8s manifests). It's safe to upgrade beyond 1.29 according to [this](spring-projects/spring-boot#32228 (comment)). However, snakeyaml 1.32 has a [feature](https://bitbucket.org/snakeyaml/snakeyaml/issues/547/restrict-the-size-of-incoming-data) to restrict the size of incoming data to 3 MB by default ([PR](https://bitbucket.org/snakeyaml/snakeyaml/pull-requests/22)), and spring boot versions <= 3.0.7 are not equipped to modify this. So, use 1.31 in order to avoid the limit till upgrade >= 3.0.7 and to resolve CVE-2022-25857 and CVE-2022-38749. before: | | +--- org.yaml:snakeyaml:1.29 -> 1.27 (c) | +--- org.yaml:snakeyaml:{strictly 1.27} -> 1.27 (c) after: | | +--- org.yaml:snakeyaml:1.29 -> 1.31 (c) | +--- org.yaml:snakeyaml:1.31 (c)
dbyron-sf
force-pushed
the
snakeyaml-unpin
branch
from
1a233c7
to
e86347c
Compare
dbyron-sf
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring boot 2.6.15 brings in snakeyaml 1.29, which fails to parse yaml (including some k8s manifests). It's safe to upgrade beyond 1.29 according to this. However, snakeyaml 1.32 has a feature to restrict the size of incoming data to 3 MB by default (PR), and spring boot versions <= 3.0.7 are not equipped to modify this. So, use 1.31 in order to avoid the limit till upgrade >= 3.0.7 and to resolve CVE-2022-25857 and CVE-2022-38749.
before:
after: