Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App fails to start when it depends on thymeleaf-extras-springsecurity5 but does not have Spring Security on the classpath #28967

Closed
wants to merge 1 commit into from
Closed

App fails to start when it depends on thymeleaf-extras-springsecurity5 but does not have Spring Security on the classpath #28967

wants to merge 1 commit into from

Conversation

terminux
Copy link
Contributor

Closes gh-28947

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 10, 2021
@terminux terminux mentioned this pull request Dec 10, 2021
Closed
@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 10, 2021
@snicoll snicoll added this to the 2.5.x milestone Dec 10, 2021
@snicoll snicoll self-requested a review December 10, 2021 06:24
@snicoll snicoll changed the title Add Spring Security dependency check for ThymeleafSecurityDialectConfiguration App fails to start when it depends on thymeleaf-extras-springsecurity5 but does not have Spring Security on the classpath Dec 10, 2021
@terminux
Copy link
Contributor Author

Thanks @wilkinsona , nice suggestions. I updated the PR and it's ready for your review again.

@snicoll snicoll self-assigned this Dec 10, 2021
@snicoll snicoll mentioned this pull request Dec 10, 2021
Closed
snicoll pushed a commit that referenced this pull request Dec 10, 2021
@terminux @snicoll
Check for the presence of Spring Security
4462f91 
See gh-28967
snicoll added a commit that referenced this pull request Dec 10, 2021
@snicoll
Polish "Check for the presence of Spring Security"
f6f5aec 
See gh-28967
@snicoll snicoll closed this in 96baef4 Dec 10, 2021
@snicoll
Copy link
Member

snicoll commented Dec 10, 2021

@terminux thanks for making your first contribution to Spring Boot. There's no need to list all 3 classes so I've only kept what @wilkinsona suggested, see f6f5aec.

@snicoll snicoll modified the milestones: 2.5.x, 2.5.8 Dec 10, 2021
@terminux terminux mentioned this pull request May 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snicoll snicoll Awaiting requested review from snicoll

@wilkinsona wilkinsona Awaiting requested review from wilkinsona

Assignees

@snicoll snicoll

Labels
type: bug A general bug
Projects
None yet
Milestone
2.5.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@terminux @snicoll @wilkinsona @spring-projects-issues