Modify DefaultMessageListenerContainer javadoc #25503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue spring-projects#15210 reports problem with maxMessagePerTask and CachingConnectionFactory. Result of the issue is javadoc section which discourages from CachingConnectionFactory with dynamic scalling. But dynamic scaling described in the javadoc is achieved by method setMaxConcurrentConsumers, not setMaxMessagePerTask. I can't find issue 15210 details, but CachingConnectionFactory is typical setup in Spring world. For example, guide https://github.com/spring-guides/gs-messaging-jms creates context with DefaultMessageListenerContainer + CachingConnectionFactory. For that reason I assume that DefaultMessageListenerContainer + CachingConnectionFactory + dynamic scaling with setMaxConcurrentConsumers is correct. I deleted misleading Javadoc section and added relevant discouraging section to Javadoc of method setMaxMessagePerTask If I am wrong please reject my PR
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
in: messaging
|
I've edited your comment to improve the formatting. You might want to check out this Mastering Markdown guide for future reference. |
jhoeller
removed
the
status: waiting-for-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #15210 reports a problem with
maxMessagePerTaskandCachingConnectionFactory. The result of the issue is javadoc section which discouragesCachingConnectionFactorywith dynamic scaling.But dynamic scaling described in the javadoc is achieved by method
setMaxConcurrentConsumers, notsetMaxMessagePerTask.I can't find issue 15210 details, but
CachingConnectionFactoryis typical setup in Spring world. For example, the guide https://github.com/spring-guides/gs-messaging-jms creates a context withDefaultMessageListenerContainer+CachingConnectionFactory.For that reason I assume that
DefaultMessageListenerContainer+CachingConnectionFactory+ dynamic scaling withsetMaxConcurrentConsumersis correct. I deleted misleading Javadoc section and added relevant discouraging section to Javadoc of methodsetMaxMessagePerTask.If I am wrong please reject my PR.