Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify DefaultMessageListenerContainer javadoc #25503

Closed
wants to merge 1 commit into from
Closed

Modify DefaultMessageListenerContainer javadoc #25503

wants to merge 1 commit into from

Commits on Aug 1, 2020

  1. Modify DefaultMessageListenerContainer javadoc 

    Issue spring-projects#15210 reports problem with maxMessagePerTask and CachingConnectionFactory. Result of the issue is javadoc section which discourages from CachingConnectionFactory with dynamic scalling.
But dynamic scaling described in the javadoc is achieved by method setMaxConcurrentConsumers, not setMaxMessagePerTask. 
I can't find issue 15210 details, but CachingConnectionFactory is typical setup in Spring world. For example, guide https://github.com/spring-guides/gs-messaging-jms creates context with DefaultMessageListenerContainer + CachingConnectionFactory.

For that reason I assume that DefaultMessageListenerContainer  + CachingConnectionFactory + dynamic scaling with setMaxConcurrentConsumers is correct. I deleted misleading Javadoc section and added relevant discouraging section to Javadoc of method setMaxMessagePerTask

If I am wrong please reject my PR
    @michaldo
    michaldo committed Aug 1, 2020
    Configuration menu
    Copy the full SHA
    13e7cf3 View commit details
    Browse the repository at this point in the history