Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo and use of componentry #27852

Closed
wants to merge 2 commits into from
Closed

Fix typo and use of componentry #27852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
040e236
Fix Typo
xixingya Dec 24, 2021
944dffe
Fix Typo
xixingya Dec 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions spring-context/src/main/java/org/springframework/scheduling/annotation/EnableAsync.java
View file
Open in desktop
@@ -1,5 +1,5 @@
/*
* Copyright 2002-2018 the original author or authors.
* Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -134,7 +134,7 @@
* setting of the <em>thread name prefix</em> of the {@code Executor}; this is because
* the {@code <task:executor>} element does not expose such an attribute. This
* demonstrates how the JavaConfig-based approach allows for maximum configurability
* through direct access to actual componentry.
* through direct access to actual component.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a typo: "componentry" is semantically correct here.

Although the wording could be improved, the suggested change is grammatically incorrect.

*
* <p>The {@link #mode} attribute controls how advice is applied: If the mode is
* {@link AdviceMode#PROXY} (the default), then the other attributes control the behavior
Expand Down
2 changes: 1 addition & 1 deletion spring-context/src/main/java/org/springframework/scheduling/annotation/EnableScheduling.java
View file
Open in desktop
Expand Up @@ -180,7 +180,7 @@
* instead of a custom <em>{@code Trigger}</em> implementation; this is because the
* {@code task:} namespace {@code scheduled} cannot easily expose such support. This is
* but one demonstration how the code-based approach allows for maximum configurability
* through direct access to actual componentry.
* through direct access to actual component.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a typo: "componentry" is semantically correct here.

Although the wording could be improved, the suggested change is grammatically incorrect.

*
* <p><b>Note: {@code @EnableScheduling} applies to its local application context only,
* allowing for selective scheduling of beans at different levels.</b> Please redeclare
Expand Down
4 changes: 2 additions & 2 deletions spring-web/src/main/java/org/springframework/http/server/RequestPath.java
View file
Open in desktop
@@ -1,5 +1,5 @@
/*
* Copyright 2002-2020 the original author or authors.
* Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -23,7 +23,7 @@
/**
* Specialization of {@link PathContainer} that sub-divides the path into a
* {@link #contextPath()} and the remaining {@link #pathWithinApplication()}.
* The lattery is typically used for request mapping within the application
* The latter is typically used for request mapping within the application
* while the former is useful when preparing external links that point back to
* the application.
*
Expand Down
2 changes: 1 addition & 1 deletion spring-web/src/main/java/org/springframework/web/SpringServletContainerInitializer.java
View file
Open in desktop
Expand Up @@ -129,7 +129,7 @@ public class SpringServletContainerInitializer implements ServletContainerInitia
* method will be invoked on each instance, delegating the {@code ServletContext} such
* that each instance may register and configure servlets such as Spring's
* {@code DispatcherServlet}, listeners such as Spring's {@code ContextLoaderListener},
* or any other Servlet API componentry such as filters.
* or any other Servlet API component such as filters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a typo: "componentry" is semantically correct here.

Although the wording could be improved, the suggested change is grammatically incorrect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you review but can I ask a question in this word "component" change to the "componentry" means, because componentry is not in the dictionary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a typo: "componentry" is semantically correct here.

Although the wording could be improved, the suggested change is grammatically incorrect.

I am also not the English native speaker,I can not understand at the word add ry means what,so how to change the word can grammatically correct.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what dictionary are you using?
https://www.dictionary.com/browse/componentry

* @param webAppInitializerClasses all implementations of
* {@link WebApplicationInitializer} found on the application classpath
* @param servletContext the servlet context to be initialized
Expand Down