Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo and use of componentry #27852

Closed
wants to merge 2 commits into from

Conversation

xixingya
Copy link
Contributor

Fix lattery and componentry word

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 24, 2021
@snicoll snicoll added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 24, 2021
@snicoll snicoll added this to the 5.3.15 milestone Dec 24, 2021
@snicoll snicoll self-assigned this Dec 24, 2021
@snicoll snicoll changed the title FixTypo Fix typos Dec 24, 2021
@@ -134,7 +134,7 @@
* setting of the <em>thread name prefix</em> of the {@code Executor}; this is because
* the {@code <task:executor>} element does not expose such an attribute. This
* demonstrates how the JavaConfig-based approach allows for maximum configurability
* through direct access to actual componentry.
* through direct access to actual component.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a typo: "componentry" is semantically correct here.

Although the wording could be improved, the suggested change is grammatically incorrect.

@@ -180,7 +180,7 @@
* instead of a custom <em>{@code Trigger}</em> implementation; this is because the
* {@code task:} namespace {@code scheduled} cannot easily expose such support. This is
* but one demonstration how the code-based approach allows for maximum configurability
* through direct access to actual componentry.
* through direct access to actual component.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a typo: "componentry" is semantically correct here.

Although the wording could be improved, the suggested change is grammatically incorrect.

@@ -129,7 +129,7 @@
* method will be invoked on each instance, delegating the {@code ServletContext} such
* that each instance may register and configure servlets such as Spring's
* {@code DispatcherServlet}, listeners such as Spring's {@code ContextLoaderListener},
* or any other Servlet API componentry such as filters.
* or any other Servlet API component such as filters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a typo: "componentry" is semantically correct here.

Although the wording could be improved, the suggested change is grammatically incorrect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you review but can I ask a question in this word "component" change to the "componentry" means, because componentry is not in the dictionary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a typo: "componentry" is semantically correct here.

Although the wording could be improved, the suggested change is grammatically incorrect.

I am also not the English native speaker,I can not understand at the word add ry means what,so how to change the word can grammatically correct.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what dictionary are you using?
https://www.dictionary.com/browse/componentry

@snicoll
Copy link
Member

snicoll commented Dec 24, 2021

IMO, it is worth reviewing as the current phrasing isn't friendly to those, like me, who aren't English native speaker.

@snicoll snicoll modified the milestones: 5.3.15, 6.0.0-M2 Dec 29, 2021
@snicoll snicoll changed the title Fix typos Fix typo and use of componentry Dec 29, 2021
snicoll pushed a commit that referenced this pull request Dec 29, 2021
snicoll added a commit that referenced this pull request Dec 29, 2021
@snicoll snicoll closed this in eb50229 Dec 29, 2021
@snicoll
Copy link
Member

snicoll commented Dec 29, 2021

@xixingya thanks for spotting these, I hope the polished phrasing is more accessible to everyone.

@sbrannen
Copy link
Member

sbrannen commented Jan 3, 2022

@xixingya thanks for spotting these,

👍

I hope the polished phrasing is more accessible to everyone.

Yep, it's definitely more accessible to non-native speakers like that. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants