Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a method in MockHttpServletRequestBuilder to set remote address #30497

Closed
wants to merge 3 commits into from
Closed

Introduce a method in MockHttpServletRequestBuilder to set remote address #30497

wants to merge 3 commits into from

Conversation

leewin12
Copy link
Contributor

@leewin12 leewin12 commented May 16, 2023 •
edited by sbrannen

Introduce a method in MockHttpServletRequestBuilder to set the remote server address.

This PR was discussed in gh-30484.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 16, 2023
sbrannen
sbrannen requested changes May 16, 2023
View reviewed changes
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR looks pretty good.

I've only requested a few minor changes.

...st/java/org/springframework/test/web/servlet/request/MockHttpServletRequestBuilderTests.java Outdated Show resolved Hide resolved
...rc/main/java/org/springframework/test/web/servlet/request/MockHttpServletRequestBuilder.java Outdated Show resolved Hide resolved
...rc/main/java/org/springframework/test/web/servlet/request/MockHttpServletRequestBuilder.java Outdated Show resolved Hide resolved
...st/java/org/springframework/test/web/servlet/request/MockHttpServletRequestBuilderTests.java Outdated Show resolved Hide resolved
@sbrannen sbrannen changed the title Introduce a method in MockHttpServletRequestBuilder to set remote address Introduce a method in MockHttpServletRequestBuilder to set remote address May 16, 2023
@sbrannen sbrannen added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 16, 2023
@sbrannen sbrannen self-assigned this May 16, 2023
@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels May 16, 2023
@sbrannen sbrannen mentioned this pull request May 16, 2023
Closed
leewin12 and others added 2 commits May 17, 2023 00:08
@leewin12 @sbrannen
Apply suggestions from code review
6a32c2e 
Co-authored-by: Sam Brannen <sam@sambrannen.com>
@leewin12
Reinstate the blank line
6783610
@sbrannen sbrannen removed the status: waiting-for-feedback We need additional information before we can continue label May 16, 2023
@sbrannen sbrannen added this to the 6.1.0-M1 milestone May 16, 2023
@sbrannen sbrannen closed this in e5ee369 May 16, 2023
@sbrannen
Copy link
Member

Congratulations on submitting your first PR for the Spring Framework! 👍

This has been merged into main.

Thanks

@leewin12
Copy link
Contributor Author

Thank you, @sbrannen! Could we backport this to 5.x? Spring Boot 2.x still relies on 5.x.

@leewin12 leewin12 mentioned this pull request May 21, 2023
Closed
@sbrannen sbrannen added the status: backported An issue that has been backported to maintenance branches label May 23, 2023
@sbrannen sbrannen modified the milestones: 6.1.0-M1, 6.0.10 May 23, 2023
@sbrannen
Copy link
Member

Reopening to introduce in 6.0.x.

@sbrannen sbrannen reopened this May 23, 2023
@sbrannen sbrannen removed the status: backported An issue that has been backported to maintenance branches label May 23, 2023
@sbrannen sbrannen closed this in fa85657 May 23, 2023
mdeinum pushed a commit to mdeinum/spring-framework that referenced this pull request Jun 29, 2023
@leewin12 @mdeinum
Introduce method in MockHttpServletRequestBuilder to set remote address
5846b92 
Co-authored-by: Sam Brannen <sam@sambrannen.com>
Closes spring-projectsgh-30497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrannen sbrannen sbrannen approved these changes

Assignees

@sbrannen sbrannen

@leewin12 leewin12

Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leewin12 @sbrannen @spring-projects-issues