Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing @Nullable annotations in ContentDisposition.Builder #30820

Closed
wants to merge 2 commits into from
Closed

Add missing @Nullable annotations in ContentDisposition.Builder #30820

wants to merge 2 commits into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Jul 5, 2023

This PR adds missing @Nullable annotations in ContentDisposition.Builder.

See 7f9349b

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 5, 2023
@sdeleuze sdeleuze self-assigned this Jul 11, 2023
@sdeleuze sdeleuze added this to the 6.0.11 milestone Jul 11, 2023
@sdeleuze sdeleuze added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 11, 2023
@sdeleuze
Copy link
Contributor

sdeleuze commented Jul 11, 2023 •
edited

Thanks, any reason with name(String name) does not get a @Nullable annotation in this PR?

@izeye
Copy link
Contributor Author

izeye commented Jul 11, 2023

@sdeleuze Ah, it seems I just missed that. I added 8789f14 for it.

@sdeleuze sdeleuze closed this in 8ecedb8 Jul 11, 2023
@sdeleuze
Copy link
Contributor

Merged, I added @Nullable on the Charset parameter as well.

@izeye izeye deleted the nullable branch July 11, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sdeleuze sdeleuze

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@izeye @sdeleuze @spring-projects-issues