Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing @Nullable annotations in ContentDisposition.Builder #30820

Closed
wants to merge 2 commits into from
Closed

Add missing @Nullable annotations in ContentDisposition.Builder #30820

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbdb445
Add missing @Nullable annotations in ContentDisposition.Builder
izeye Jul 5, 2023
8789f14
Add missing @Nullable annotations in ContentDisposition.Builder.name()
izeye Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 7 additions & 7 deletions spring-web/src/main/java/org/springframework/http/ContentDisposition.java
View file
Open in desktop
Expand Up @@ -704,7 +704,7 @@ public interface Builder {
/**
* Set the value of the {@literal name} parameter.
*/
Builder name(String name);
Builder name(@Nullable String name);

/**
* Set the value of the {@literal filename} parameter. The given
Expand All @@ -713,7 +713,7 @@ public interface Builder {
* be escaped with a backslash, e.g. {@code "foo\"bar.txt"} becomes
* {@code "foo\\\"bar.txt"}.
*/
Builder filename(String filename);
Builder filename(@Nullable String filename);

/**
* Set the value of the {@code filename} that will be encoded as
Expand All @@ -724,7 +724,7 @@ public interface Builder {
* <a href="https://tools.ietf.org/html/rfc7578#section-4.2">RFC 7578, Section 4.2</a>
* and also RFC 5987 mention it does not apply to multipart requests.
*/
Builder filename(String filename, Charset charset);
Builder filename(@Nullable String filename, Charset charset);

/**
* Set the value of the {@literal size} parameter.
Expand All @@ -733,7 +733,7 @@ public interface Builder {
* to be removed in a future release.
*/
@Deprecated
Builder size(Long size);
Builder size(@Nullable Long size);

/**
* Set the value of the {@literal creation-date} parameter.
Expand All @@ -742,7 +742,7 @@ public interface Builder {
* to be removed in a future release.
*/
@Deprecated
Builder creationDate(ZonedDateTime creationDate);
Builder creationDate(@Nullable ZonedDateTime creationDate);

/**
* Set the value of the {@literal modification-date} parameter.
Expand All @@ -751,7 +751,7 @@ public interface Builder {
* to be removed in a future release.
*/
@Deprecated
Builder modificationDate(ZonedDateTime modificationDate);
Builder modificationDate(@Nullable ZonedDateTime modificationDate);

/**
* Set the value of the {@literal read-date} parameter.
Expand All @@ -760,7 +760,7 @@ public interface Builder {
* to be removed in a future release.
*/
@Deprecated
Builder readDate(ZonedDateTime readDate);
Builder readDate(@Nullable ZonedDateTime readDate);

/**
* Build the content disposition.
Expand Down