-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove guava and use java 8 constructs (#1082) #2082
Conversation
Thank you @copa2. Will definitely pull in this change after the 2.8.0 release. Currently the library supports down to java 6 and this is a breaking change => up rev to 3.0.0 after this release. |
Hi dilipkrish Just checked the failure I receive from circleci. Line 57 in ec9af57
Each entry receives a new OperationCachingEquivalence which calls the Wrapper. Normally you only create one Equivalence object and then call wrap on the same. If I change the code on master like this i will get the same failure. To fix it properly we should probably reconsider what is equivalent for the Operation. Currently it fails in the PetStoreResource for getPetInTx and getPetInCA. It is looked equivalent, as the key data is the same. Probably we have additionally to check the static params or use the methodName. Any suggestions? |
# Conflicts: # springfox-spring-web/src/main/java/springfox/documentation/spring/web/readers/parameter/ExpansionContext.java # springfox-spring-web/src/test/java/springfox/documentation/spring/web/dummy/controllers/BugsController.java
This PR is replaced by PR #2086, due unneeded crlf. |
This PR removes the guava library dependency with java 8 constructs.
(Fix issue #1082)
The main reason is that other code also uses guava in a incompatible version and guava is not always binary compatible.
Incompatiblilites:
What is missing:
Checked alternatives: