-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove guava and use java8 constructs (#1082) #2086
Conversation
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well this is the behavior like it was before with Guava check.
} else { | ||
other = (T)obj; | ||
} | ||
if(delegate == other) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove the Equivalence class when this is merged. I think normal wrappers for these use cases are ok. I keep it as similiar as before so that merging from upstream is simpler.
Hi dilipkrish Just checked the failure I receive from circleci. Line 57 in ec9af57
Each entry receives a new OperationCachingEquivalence which calls the Wrapper. Normally you only create one Equivalence object and then call wrap on the same. If I change the code on master like this I will get the same failure.
@dilipkrish
So in my opinion the test Or is there some other reason I don't understand? |
@copa2 thank you for the PR! I've pulled in the PR to remove guava dependency |
Has this problem been solved? |
This PR removes the guava library dependency with java 8 constructs.
(Fix issue #1082)
The main reason is that other code also uses guava in a incompatible version and guava is not always binary compatible.
Incompatiblilites:
What is missing:
Checked alternatives:
Using shading plugin to shade guava. This makes each sub-project artifact big due whole guava library has to be shaded into the artifact.
NOTE: This PR replaces previous PR #2082 due unneeded changes regarding crlf.