Work around KT-52315 #1248
Merged
Work around KT-52315 #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://youtrack.jetbrains.com/issue/KT-52315 `header` and `impl` are deprecated and do not behave as modifier keywords anymore... except in this specific case, seemingly.
|
Thoughts on just adding these two to |
|
That would make them needlessly escaped everywhere and available to use as a modifier when calling APIs despite not actually being modifiers. |
|
I could add them to Util.kt |
Egorand
approved these changes
May 9, 2022
There was a problem hiding this comment.
Ah, KEYWORDS is what I actually wanted to say. I like this solution better, @JakeWharton - not merging for now if you have other thoughts.
kotlinpoet/src/test/java/com/squareup/kotlinpoet/TypeSpecTest.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Egor Andreevich <github@egorand.dev>
|
Don't have a strong opinion. I was fine with the localized workaround for the sole place where the syntax was broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://youtrack.jetbrains.com/issue/KT-52315
headerandimplare deprecated and do not behave as modifierkeywords anymore... except in this specific case, seemingly.