-
-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with Nerdbank.GitVersioning #1299
base: develop
Are you sure you want to change the base?
Conversation
IncludeSymbols
Co-authored-by: Rob Hague <rob.hague00@gmail.com>
Co-authored-by: Rob Hague <rob.hague00@gmail.com>
Interesting. Would this change how one creates a release? If so, what would be the steps required? |
From reading the doc about nbgv, the first step is to run
Then grab a cup of coffee and wait the Appveyor to build the project, generate the nuget package, test the project, and finally deploy the nuget package to nuget.org. |
…his particular project needs versioning. include package version in ThisAssembly and use nuget package version for the SSH client version. Since we define the precision of nuget package to "build", it has 3 digits. Nuget package version is unique which should be suffient.
I get a weird error when building this branch
|
It seems to be a bug in the Nerdbank package, where it does not correctly handle lightweight tags in .git/ref/tags (e.g. 2023.0.1). In a fresh clone, the tags are in .git/packed-refs which are handled correctly, hence it passing in CI. In my local copy of the repo, the tags are in .git/ref/tags and it is assuming they are all annotated tags. |
I've not forgotten about this PR, I just want to read up some more on the configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that 2024.0.0 already has the commit info tagged to the dll (probably because of sourcelink?):
In that case, I am not sure if there still benefits to this change. I am not sure the release process needs to change (it seems simple enough), but as I don't make the releases I think I will have to defer to @WojciechNagorski as to whether to take this change.
}, | ||
"release": { | ||
"tagName" : "{version}", | ||
"branchName" : "master", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be e.g.
"branchName" : "master", | |
"branchName" : "release/{version}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the curernt release is based on master
branch with tag?
Not very familar with current release process, but it seems to be some manual work? |
Yes it is manual |
I guess the current release process is based on https://github.com/sshnet/BuildTools and https://github.com/sshnet/SSH.NET/blob/develop/build/build.proj, am I right? @WojciechNagorski |
Currently it is just dotnet pack right now. |
No description provided.