Add the array-bracket-spacing rule

[flippidippi]

Per discussion here
standard/standard#609 (comment) and issue here standard/standard#1203, add "array-bracket-spacing" rule set to "never".

[flippidippi]

Anyone want to approve the merge request? Simple change that was already approved in the issues.

[justinkalland]

Running this on the ecosystem causes 28 to fail. I also had to --fix on Standard itself to get tests to pass.

{
  "extends": ["standard", "standard-jsx"],
  "rules": {
    "array-bracket-spacing": ["error", "never"]
  }
}

1..186
# tests 186
# pass  158
# fail  28

Here are the failing repos:

• semistandard
• parse-torrent
• buffer
• virtual-element
• re-emitter
• webtorrent
• run-waterfall
• glob-promise
• magnet-uri
• standard-engine
• bittorrent-dht
• bittorrent-tracker
• hosted-git-info
• deglob
• create-torrent
• blob-to-buffer
• prefix-style
• standard-packages
• npm-install-package
• chrome-dgram
• markdown-it-decorate
• gl-vignette-background
• stringify-clone
• testdata-w3c-json-form
• simple-media-element
• standard-json
• studynotes
• webtorrent-desktop

[flippidippi]

So what are the next steps? Is that a reasonable amount? Would obviously need a breaking version bump.

[justinkalland]

I am a newer contributor here. But from what I have seen the next step is having consensus to include this addition. It appears consensus is achieved by input from the community with the final decision by the maintainers. I love Standard but would like to see a better process for proposing and adopting changes within the community. It is something I have been thinking about and planned on bringing up in the main repo. And to me it is necessary for Standard to reach its full potential as the standard.

[LinusU]

I love Standard but would like to see a better process for proposing and adopting changes within the community. It is something I have been thinking about and planned on bringing up in the main repo. And to me it is necessary for Standard to reach its full potential as the standard.

Agreed 👍, we should also formalize the release process as well!

Here are the failing repos:

I've updated testdata-w3c-json-form so that should pass now...

It seems like a lot of the packages are maintained by @feross, so it would be great if he could weigh in on what he thinks about the rule. If he is 👍 then I think we should start sending pull requests to failing repos, and then merging this (e.g. like in #124)

[feross]

This change will be included in standard 13.

I updated all the packages I have push access to, but there still remain several packages that need an update. It would be great if those who are interested in this change on this thread could send PRs to these repos! (In the meantime, I disabled the tests against these repos which is not ideal)