-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements to 90 Day Uptime Visualization #257
base: dev
Are you sure you want to change the base?
Conversation
wow, this looks good! I agree that the thresholds could be configurable, but this is already an improvement, so no worries :) also, thanks for fixing the dev setup - I've been procrastinating on that for, what, a year now? |
Glad you like it! Happy to help haha, sometimes it's the small things that are just hard to get to! Looks like I might have broken the tests with changing the sample data 😵 Though when I took a look at the failing tests it doesn't seem to be that 🤔 |
Love this PR. Thank you @OstlerDev! |
I built and released a version on Docker Hub so that anybody who wants can test this out.
Note: Docker building was broken, but I fixed it, and included this fix in this new Pull Request: #259 |
Alright, that should fix the issue 😸 |
Keep last 365 days of records and fix issue with uptime calculation
Looks like there was an issue with the testing workflows building the Go app properly. I saw that it might be an issue with newer versions, so I pinned the tests to use Go v1.20.0 to match the Main Dockerfile exactly. It looks like it was installing Go v1.20.14 I believe, so maybe using an older version will work? I will attempt to run the worlflows locally to see if I can get them working as expected. |
and also check the go version
Alright @jemand771, I finally got the tests working 😵 Turns out there was a couple errors in the test pipelines, but fixing a couple things with the Go version/setup seems to make them run just fine when I tested them on my personal GitHub repo 😸 Hope they also work for you, they are running like a charm for me now 😄 (other than |
Sorry for being silent, is this merge good to go? |
something's up with the tests (but only somtimes?) that I'd like to sort out first: #282 |
Overview
The "Last 90 day" view in my opinion could be further utilized to display the services status for the day. I have made some changes that I think look good while adding much more detail to the service's status for a particular day. The changes display if a service was online, or if there was an outage, how severe the outage was based on the number of bad data points we recieved.
Currently the application will display a grey cell for no issues, and a bright red cell if there is even a single issue. In my opinion showing a server as "red" means it was completely offline or severely impaired, and missing a single ping shouldn't be cause for showing an "outage" for the full day.
It was that reason that I decided it might be nice if it was a little more dynamic.
Changelog
Fixed
Changed
Added
#e9e9e9
Light Grey for days with no data#4CAF50
Green for days with 100% uptime#98EE99
(Minor outage) Light green for days with between 1-30 failures (up to 30 minutes of downtime)#FFEB3B
(Moderate outage) Yellow for days with between 31-120 failures (up to 2 hours of downtime)#FF9800
(Major outage) Orange for days with between 121-240 failures (up to 4 hours of downtime)#F44336
(Critical outage) Red for days with over 240 failures (over 4 hours of downtime)Ideas for improvement
It would be great if the outage severities could be set inside the settings of Statping-ng, I just didn't have time at the moment to add it, but I did leave everything very configurable in the Vue file in case someone wants to get around to it eventually. If I get some time I will try to add it in another MR, but no promises.
Preview
What it used to look like