Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Workflows for Postman Tests #282

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

OstlerDev
Copy link

@OstlerDev OstlerDev commented Mar 27, 2024

I got the tests fixed/passing, turns out it just needed a small update 馃樃 Hope this helps @jemand771 !! Let me know if you would like any more like consistent help with this repository, I imagine it might be kinda overwhelming taking on everything alone. If you want to chat about getting some more help, add me on Discord at ostlerdev.

Figured I would pull it out to a separate pull request to keep things as clean as possible.

Changelog

Fixed

  • GitHub Workflow for Postman tests!
    • Use Go 1.21.8
    • Add GOPROXY and fix Env var setup

(changes originally included in #257)

@OstlerDev
Copy link
Author

@jemand771 Just giving this a small bump/reminder, no urgency at all. I just figured it might help if this got merged in so that the other merge requests can be properly reviewed 馃樃 Let me know if you need any help!

@jemand771
Copy link
Member

heya, sorry + thanks for the reminder

I still don't get why this broke 馃 was there some change upstream that now requires the GOPROXY variable to be set?

also, the ${{ needs.data.outputs.go_version }} part was there so we can have a consistent go version across all of CI without hardcoding it in like 20 steps. I'd prefer if we could keep that

@adamboutcher
Copy link
Collaborator

heya, sorry + thanks for the reminder

I still don't get why this broke 馃 was there some change upstream that now requires the GOPROXY variable to be set?

also, the ${{ needs.data.outputs.go_version }} part was there so we can have a consistent go version across all of CI without hardcoding it in like 20 steps. I'd prefer if we could keep that

Do we need @OstlerDev to make a couple of changes? To be ready to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants