Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting some code review - JSONDivider #735

Closed
wants to merge 2 commits into from

Conversation

thswlsqls
Copy link

Hi, stleary.
I'm Eunbin , a korean software developer.

I'm writing you to request some code review.

I'm glad to know your JSON-java(org.json) and thank you for providing it as open source.
Because it really helps me to work successfully in my company.

While using it, I developed an additional functions which supports to divide JSON string.
In my JSON datasets used at company, it operates without errors and returns results i expected.

Can you check JSONDivider.java and Docs/JSONDivider/*
and examine whether it can helps other developers or not?

Thank you and best regards,

@thswlsqls thswlsqls changed the title Requesting some code review Requesting some code review - JSONDivider Apr 14, 2023
@stleary
Copy link
Owner

stleary commented Apr 14, 2023

@thswlsqls Thanks for the pull request. I don't think there is a compelling use case for adding this feature at this time. You can find more information about what kind of changes are allowed in the readme and the FAQ. Going forward, pull requests are generally required to include unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants