Bump open-cluster-management.io/addon-framework from 0.1.0 to 0.3.0

[dependabot]

Bumps open-cluster-management.io/addon-framework from 0.1.0 to 0.3.0.

Commits

• 25c422e Add 0.3 change log (#90)
• 6b37719 Fix spec comparison in applyWork (#89)
• 9546e6c fix typo (#88)
• 210d9c9 fix readme url (#87)
• 100a023 feat: addon approver v1beta1 support (#85)
• edd1600 "fix Klog flags disppeared (#83)
• f2fc48e Feat: Conditional CSR controller spawning (#84)
• 9c08db9 should apply pre-delete hook when the managedCluster is deleting (#81)
• df7ea69 Add work probe mode (#77)
• f3917ca Add an install strategy by label selector (#79)
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[openshift-ci]

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a stolostron member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tpantelis]

/ok-to-test

[tpantelis]

@skitt In order to bump to addon-framework 0.3.0, we need to bump K8s to 0.23.*. This also requires bumping controller-runtime to v0.11.2 which builds fine but then we run into an issue with the integration tests:

./integration.test -ginkgo.slowSpecThreshold=15 -ginkgo.v -ginkgo.failFast
panic: mkdir /.cache: permission denied

goroutine 1 [running]:
sigs.k8s.io/controller-runtime/pkg/internal/testing/addr.init.0()
	/go/src/github.com/stolostron/submariner-addon/vendor/sigs.k8s.io/controller-runtime/pkg/internal/testing/addr/manager.go:51 +0xda

This is actually an issue you fixed upstream with kubernetes-sigs/controller-runtime#1800 but it's in v0.12.0 which needs K8s 0.24.* which breaks the openshift/library-go. I then bumped to openshift/library-go@release-4.12 which uses K8s 0.24.0 and the integration tests succeeded but the verify job still failed ☹️ :

bash ./vendor/k8s.io/code-generator/generate-groups.sh client,lister,informer github.com/stolostron/submariner-addon/pkg/client/submarinerconfig github.com/stolostron/submariner-addon/pkg/apis submarinerconfig:v1alpha1 --go-header-file hack/../hack/../hack/boilerplate.txt --verify-only
install: target 'k8s.io/code-generator/cmd/deepcopy-gen' is not a directory

Any ideas on that error?

[tpantelis]

/test golangci-lint

[tpantelis]

@skitt In order to bump to addon-framework 0.3.0, we need to bump K8s to 0.23.*. This also requires bumping controller-runtime to v0.11.2 which builds fine but then we run into an issue with the integration tests:

./integration.test -ginkgo.slowSpecThreshold=15 -ginkgo.v -ginkgo.failFast
```shell
bash ./vendor/k8s.io/code-generator/generate-groups.sh client,lister,informer github.com/stolostron/submariner-addon/pkg/client/submarinerconfig github.com/stolostron/submariner-addon/pkg/apis submarinerconfig:v1alpha1 --go-header-file hack/../hack/../hack/boilerplate.txt --verify-only
install: target 'k8s.io/code-generator/cmd/deepcopy-gen' is not a directory

Any ideas on that error?

I downgraded k8s.io/code-generator to v0.22.1 and now the verify job succeeds. Go figure.

[skitt]

bash ./vendor/k8s.io/code-generator/generate-groups.sh client,lister,informer github.com/stolostron/submariner-addon/pkg/client/submarinerconfig github.com/stolostron/submariner-addon/pkg/apis submarinerconfig:v1alpha1 --go-header-file hack/../hack/../hack/boilerplate.txt --verify-only
install: target 'k8s.io/code-generator/cmd/deepcopy-gen' is not a directory

Any ideas on that error?

Yes, see https://github.com/stolostron/submariner-addon/pull/279/files#diff-149dfe7bb29d1191dceae3a52915e750e64b7f87257a5fb309c29d3056e2a95d

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

5.0% Coverage
88.1% Duplication

[skitt]

/test unit

[skitt]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tpantelis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tpantelis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment