Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin rollup version to 3.19.1 #21723

Merged
merged 3 commits into from Mar 22, 2023
Merged

Pin rollup version to 3.19.1 #21723

merged 3 commits into from Mar 22, 2023

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Mar 22, 2023

Closes #

Attempting to get next green again in CI, by pinning rollup to 3.19.1, the version prior to that which was released yesterday (3.20.0), which I suspect is causing our problems.

What I did

I also needed to hack in a TS ignore, and I regenerated the lockfile.

And I unpinned Vite, which had no effect: #21715

How to test

It's not possible to test locally, it seems. But hopefully CI will show us.

I wonder if we need to try to limit ourselves to a single CPU locally, somehow, to me more like CI… 🤔

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@IanVS IanVS added dependencies ci:daily Run the CI jobs that normally run in the daily job. labels Mar 22, 2023
@IanVS
Copy link
Member Author

IanVS commented Mar 22, 2023

OK, it does seem to be rollup that has caused this problem. The chromatic and e2e sandboxes are passing in this PR (though there are some other, seemingly unrelated issues which cause ci checks to be red above).

@IanVS
Copy link
Member Author

IanVS commented Mar 22, 2023

I have reported this issue in rollup/rollup#4916.

@valentinpalkovic valentinpalkovic merged commit 1630bcf into next Mar 22, 2023
18 checks passed
@valentinpalkovic valentinpalkovic deleted the vite/pin-rollup branch March 22, 2023 08:51
@IanVS IanVS mentioned this pull request Mar 23, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants