Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix compat by disabling name mangling in esbuild require #22486

Merged
merged 4 commits into from Jun 21, 2023
Merged

Core: Fix compat by disabling name mangling in esbuild require #22486

merged 4 commits into from Jun 21, 2023

Conversation

youngboy
Copy link
Contributor

Closes #19049

What I did

support stylus css preprocessor

How to test

  1. create storybook project
  2. add stylus

have only tests with vite-vue3 locally

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kylegach kylegach added the bug label May 15, 2023
@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 6, 2023
@valentinpalkovic valentinpalkovic requested a review from a team as a code owner June 6, 2023 13:57
@ndelangen ndelangen changed the title add keepNames option of interpret-requires esbuild Core: Improve compatibility, do not mangle names in interpret-requires with esbuild Jun 21, 2023
@ndelangen ndelangen merged commit 5021c4f into storybookjs:next Jun 21, 2023
48 of 49 checks passed
This was referenced Jun 21, 2023
Merged
Merged
@shilman shilman changed the title Core: Improve compatibility, do not mangle names in interpret-requires with esbuild Core: Improve compat by removing name mangling in esbuild interpret-require Jun 21, 2023
@shilman shilman changed the title Core: Improve compat by removing name mangling in esbuild interpret-require Core: Fix compat by disabling name mangling in esbuild interpret-require Jun 21, 2023
@shilman shilman changed the title Core: Fix compat by disabling name mangling in esbuild interpret-require Core: Fix compat by disabling name mangling in esbuild require Jun 21, 2023
@github-actions github-actions bot mentioned this pull request Jun 22, 2023
Merged
18 tasks
@shilman shilman mentioned this pull request Jun 23, 2023
Open
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@valentinpalkovic valentinpalkovic valentinpalkovic approved these changes

Assignees

@valentinpalkovic valentinpalkovic

Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[7.0 alpha] webpack stylus loader doesn't work anymore
5 participants
@youngboy @ndelangen @valentinpalkovic @kylegach @shilman