Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix compat by disabling name mangling in esbuild require #22486

Merged
merged 4 commits into from
Jun 21, 2023
Merged

Core: Fix compat by disabling name mangling in esbuild require #22486

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c620144
add keepNames option of interpret-requires esbuild
youngboy May 10, 2023
702bf70
fix: typo in comment
youngboy May 12, 2023
b438442
Merge branch 'next' into fix-esbuild-keepnames
valentinpalkovic Jun 6, 2023
d5204c7
Merge branch 'next' into fix-esbuild-keepnames
valentinpalkovic Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions code/lib/core-common/src/utils/interpret-require.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ export function interopRequireDefault(filePath: string) {
target: `node${process.version.slice(1)}`,
format: 'cjs',
hookIgnoreNodeModules: false,
// Some frameworks, like Stylus, rely on the 'name' property of classes or functions
// https://github.com/storybookjs/storybook/issues/19049
keepNames: true,
tsconfigRaw: `{
"compilerOptions": {
"strict": false,
Expand Down