Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Parse pnp paths in storybook metadata #23199

Merged
merged 1 commit into from Jun 23, 2023
Merged

CLI: Parse pnp paths in storybook metadata #23199

merged 1 commit into from Jun 23, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jun 23, 2023

Closes #

What I did

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 23, 2023
shilman
shilman reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @yannbf! Minor comments below

code/lib/telemetry/src/storybook-metadata.test.ts Outdated Show resolved Hide resolved
code/lib/telemetry/src/get-framework-info.ts Show resolved Hide resolved
@yannbf yannbf force-pushed the fix/parse-pnp-paths-in-metadata branch from a7014be to 01a532a Compare June 23, 2023 13:26
shilman
shilman approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🎉

@yannbf yannbf force-pushed the fix/parse-pnp-paths-in-metadata branch from 01a532a to 8fab502 Compare June 23, 2023 13:39
@yannbf yannbf force-pushed the fix/parse-pnp-paths-in-metadata branch from 8fab502 to 536ca99 Compare June 23, 2023 14:58
@shilman shilman merged commit 4f7cd07 into next Jun 23, 2023
55 of 56 checks passed
@shilman shilman deleted the fix/parse-pnp-paths-in-metadata branch June 23, 2023 16:57
This was referenced Jun 23, 2023
Merged
Merged
shilman added a commit that referenced this pull request Jun 27, 2023
@shilman
Merge pull request #23199 from storybookjs/fix/parse-pnp-paths-in-met…
a58fe68 
…adata

CLI: Parse pnp paths in storybook metadata
(cherry picked from commit 4f7cd07)
shilman added a commit that referenced this pull request Jun 27, 2023
@shilman
Merge pull request #23199 from storybookjs/fix/parse-pnp-paths-in-met…
6f6f8d7 
…adata

CLI: Parse pnp paths in storybook metadata
(cherry picked from commit 4f7cd07)
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 27, 2023
@yannbf yannbf mentioned this pull request Jun 30, 2023
Merged
5 tasks
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@koonkoon koonkoon koonkoon approved these changes

Assignees
No one assigned
Labels
bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yannbf @shilman @koonkoon @JReinhold