Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies: Remove references to api and the 2 deprecated channel packages #23384

Merged
merged 3 commits into from Jul 18, 2023
Merged

Dependencies: Remove references to api and the 2 deprecated channel packages #23384

merged 3 commits into from Jul 18, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jul 10, 2023 •
edited

What I did

I removed unused dependencies references that we deprecated

How to test

  • CI should pass
  • No errors in console due to this change

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen ndelangen self-assigned this Jul 10, 2023
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Jul 10, 2023
@ndelangen ndelangen requested a review from yannbf July 10, 2023 13:16
@ndelangen ndelangen changed the base branch from next to release/7.2 July 18, 2023 08:29
@ndelangen ndelangen merged commit cda899b into release/7.2 Jul 18, 2023
54 checks passed
@ndelangen ndelangen deleted the norbert/remove-references-to-api branch July 18, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf Awaiting requested review from yannbf

Assignees

@ndelangen ndelangen

Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ndelangen