Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies: Remove references to api and the 2 deprecated channel packages #23384

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Dependencies: Remove references to api and the 2 deprecated channel packages #23384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d462df5
remove references to `api` and the 2 deprecated channel packages
ndelangen Jul 10, 2023
3a92db6
fix, by removing it from the preview-builder for webpack in it's crea…
ndelangen Jul 10, 2023
be295d3
Merge branch 'release/7.2' into norbert/remove-references-to-api
ndelangen Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions code/builders/builder-vite/src/optimizeDeps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ const INCLUDE_CANDIDATES = [
'@storybook/addon-docs',
'@storybook/addon-essentials/docs/mdx-react-shim',
'@storybook/channels',
'@storybook/channel-postmessage',
'@storybook/channel-websocket',
'@storybook/client-api',
'@storybook/client-logger',
'@storybook/core/client',
Expand Down
2 changes: 0 additions & 2 deletions code/builders/builder-webpack5/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@
"dependencies": {
"@babel/core": "^7.22.0",
"@storybook/addons": "7.1.0-rc.2",
"@storybook/api": "7.1.0-rc.2",
"@storybook/channel-postmessage": "7.1.0-rc.2",
"@storybook/channels": "7.1.0-rc.2",
"@storybook/client-api": "7.1.0-rc.2",
"@storybook/client-logger": "7.1.0-rc.2",
Expand Down
1 change: 0 additions & 1 deletion code/builders/builder-webpack5/src/preview/iframe-webpack.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ const wrapForPnP = (input: string) => dirname(require.resolve(join(input, 'packa
const storybookPaths: Record<string, string> = {
...[
// these packages are not pre-bundled because of react dependencies
'api',
'components',
'global',
'manager-api',
Expand Down
1 change: 0 additions & 1 deletion code/frameworks/html-vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
"dependencies": {
"@storybook/addons": "7.1.0-rc.2",
"@storybook/builder-vite": "7.1.0-rc.2",
"@storybook/channel-postmessage": "7.1.0-rc.2",
"@storybook/client-api": "7.1.0-rc.2",
"@storybook/core-server": "7.1.0-rc.2",
"@storybook/html": "7.1.0-rc.2",
Expand Down
6 changes: 3 additions & 3 deletions code/lib/cli/src/automigrate/helpers/getMigrationSummary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ const allowList = [
'@storybook/csf',
// see this file for more info: code/lib/preview/src/globals/types.ts
'@storybook/addons',
'@storybook/channel-postmessage',
'@storybook/channel-websocket',
'@storybook/channel-postmessage', // @deprecated: remove in 8.0
'@storybook/channel-websocket', // @deprecated: remove in 8.0
'@storybook/channels',
'@storybook/client-api',
'@storybook/client-logger',
Expand All @@ -123,7 +123,7 @@ const allowList = [
'@storybook/components',
'@storybook/router',
'@storybook/theming',
'@storybook/api',
'@storybook/api', // @deprecated: remove in 8.0
'@storybook/manager-api',
];

Expand Down
1 change: 0 additions & 1 deletion code/lib/preview-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@
"prep": "../../../scripts/prepare/bundle.ts"
},
"dependencies": {
"@storybook/channel-postmessage": "7.1.0-rc.2",
"@storybook/channels": "7.1.0-rc.2",
"@storybook/client-logger": "7.1.0-rc.2",
"@storybook/core-events": "7.1.0-rc.2",
Expand Down
4 changes: 2 additions & 2 deletions code/lib/preview/src/globals/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ import type { globals } from './types';

// Here we map the name of a module to their VALUE in the global scope.
export const values: Required<Record<keyof typeof globals, any>> = {
'@storybook/channel-postmessage': CHANNEL_POSTMESSAGE,
'@storybook/channel-websocket': CHANNEL_WEBSOCKET,
'@storybook/channel-postmessage': CHANNEL_POSTMESSAGE, // @deprecated: remove in 8.0
'@storybook/channel-websocket': CHANNEL_WEBSOCKET, // @deprecated: remove in 8.0
'@storybook/channels': CHANNELS,
'@storybook/client-logger': CLIENT_LOGGER,
'@storybook/core-events': CORE_EVENTS,
Expand Down
4 changes: 2 additions & 2 deletions code/lib/preview/src/globals/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// Here we map the name of a module to their NAME in the global scope.
export const globals = {
'@storybook/addons': '__STORYBOOK_MODULE_ADDONS__',
'@storybook/channel-postmessage': '__STORYBOOK_MODULE_CHANNEL_POSTMESSAGE__',
'@storybook/channel-websocket': '__STORYBOOK_MODULE_CHANNEL_WEBSOCKET__',
'@storybook/channel-postmessage': '__STORYBOOK_MODULE_CHANNEL_POSTMESSAGE__', // @deprecated: remove in 8.0
'@storybook/channel-websocket': '__STORYBOOK_MODULE_CHANNEL_WEBSOCKET__', // @deprecated: remove in 8.0
'@storybook/channels': '__STORYBOOK_MODULE_CHANNELS__',
'@storybook/client-api': '__STORYBOOK_MODULE_CLIENT_API__',
'@storybook/client-logger': '__STORYBOOK_MODULE_CLIENT_LOGGER__',
Expand Down
2 changes: 0 additions & 2 deletions code/ui/manager/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@
"@fal-works/esbuild-plugin-global-externals": "^2.1.2",
"@storybook/addon-designs": "^7.0.0",
"@storybook/addons": "7.1.0-rc.2",
"@storybook/api": "7.1.0-rc.2",
"@storybook/channel-postmessage": "7.1.0-rc.2",
"@storybook/channels": "7.1.0-rc.2",
"@storybook/client-logger": "7.1.0-rc.2",
"@storybook/components": "7.1.0-rc.2",
Expand Down
10 changes: 2 additions & 8 deletions code/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5680,7 +5680,7 @@ __metadata:
languageName: unknown
linkType: soft

"@storybook/api@7.1.0-rc.2, @storybook/api@workspace:*, @storybook/api@workspace:deprecated/manager-api-shim":
"@storybook/api@workspace:*, @storybook/api@workspace:deprecated/manager-api-shim":
version: 0.0.0-use.local
resolution: "@storybook/api@workspace:deprecated/manager-api-shim"
dependencies:
Expand Down Expand Up @@ -5839,8 +5839,6 @@ __metadata:
dependencies:
"@babel/core": ^7.22.0
"@storybook/addons": 7.1.0-rc.2
"@storybook/api": 7.1.0-rc.2
"@storybook/channel-postmessage": 7.1.0-rc.2
"@storybook/channels": 7.1.0-rc.2
"@storybook/client-api": 7.1.0-rc.2
"@storybook/client-logger": 7.1.0-rc.2
Expand Down Expand Up @@ -5899,7 +5897,7 @@ __metadata:
languageName: unknown
linkType: soft

"@storybook/channel-postmessage@7.1.0-rc.2, @storybook/channel-postmessage@workspace:*, @storybook/channel-postmessage@workspace:deprecated/channel-postmessage":
"@storybook/channel-postmessage@workspace:*, @storybook/channel-postmessage@workspace:deprecated/channel-postmessage":
version: 0.0.0-use.local
resolution: "@storybook/channel-postmessage@workspace:deprecated/channel-postmessage"
dependencies:
Expand Down Expand Up @@ -6329,7 +6327,6 @@ __metadata:
dependencies:
"@storybook/addons": 7.1.0-rc.2
"@storybook/builder-vite": 7.1.0-rc.2
"@storybook/channel-postmessage": 7.1.0-rc.2
"@storybook/client-api": 7.1.0-rc.2
"@storybook/core-server": 7.1.0-rc.2
"@storybook/html": 7.1.0-rc.2
Expand Down Expand Up @@ -6464,8 +6461,6 @@ __metadata:
"@fal-works/esbuild-plugin-global-externals": ^2.1.2
"@storybook/addon-designs": ^7.0.0
"@storybook/addons": 7.1.0-rc.2
"@storybook/api": 7.1.0-rc.2
"@storybook/channel-postmessage": 7.1.0-rc.2
"@storybook/channels": 7.1.0-rc.2
"@storybook/client-logger": 7.1.0-rc.2
"@storybook/components": 7.1.0-rc.2
Expand Down Expand Up @@ -6842,7 +6837,6 @@ __metadata:
resolution: "@storybook/preview-api@workspace:lib/preview-api"
dependencies:
"@jest/globals": ^29.5.0
"@storybook/channel-postmessage": 7.1.0-rc.2
"@storybook/channels": 7.1.0-rc.2
"@storybook/client-logger": 7.1.0-rc.2
"@storybook/core-common": 7.1.0-rc.2
Expand Down
3 changes: 0 additions & 3 deletions test-storybooks/ember-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,10 @@
"@storybook/addon-viewport": "portal:../../code/addons/viewport",
"@storybook/addons": "portal:../../code/deprecated/addons",
"@storybook/angular": "portal:../../code/frameworks/angular",
"@storybook/api": "portal:../../code/lib/api",
"@storybook/blocks": "portal:../../code/lib/blocks",
"@storybook/builder-manager": "portal:../../code/builders/builder-manager",
"@storybook/builder-vite": "portal:../../code/builders/builder-vite",
"@storybook/builder-webpack5": "portal:../../code/builders/builder-webpack5",
"@storybook/channel-postmessage": "portal:../../code/lib/channel-postmessage",
"@storybook/channel-websocket": "portal:../../code/lib/channel-websocket",
"@storybook/channels": "portal:../../code/lib/channels",
"@storybook/cli": "portal:../../code/lib/cli",
"@storybook/client-api": "portal:../../code/deprecated/client-api",
Expand Down
2 changes: 0 additions & 2 deletions test-storybooks/external-docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@
"@storybook/builder-manager": "portal:../../code/builders/builder-manager",
"@storybook/builder-vite": "portal:../../code/builders/builder-vite",
"@storybook/builder-webpack5": "portal:../../code/builders/builder-webpack5",
"@storybook/channel-postmessage": "portal:../../code/lib/channel-postmessage",
"@storybook/channel-websocket": "portal:../../code/lib/channel-websocket",
"@storybook/channels": "portal:../../code/lib/channels",
"@storybook/cli": "portal:../../code/lib/cli",
"@storybook/client-api": "portal:../../code/deprecated/client-api",
Expand Down
3 changes: 0 additions & 3 deletions test-storybooks/server-kitchen-sink/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,10 @@
"@storybook/addon-viewport": "portal:../../code/addons/viewport",
"@storybook/addons": "portal:../../code/deprecated/addons",
"@storybook/angular": "portal:../../code/frameworks/angular",
"@storybook/api": "portal:../../code/lib/api",
"@storybook/blocks": "portal:../../code/lib/blocks",
"@storybook/builder-manager": "portal:../../code/builders/builder-manager",
"@storybook/builder-vite": "portal:../../code/builders/builder-vite",
"@storybook/builder-webpack5": "portal:../../code/builders/builder-webpack5",
"@storybook/channel-postmessage": "portal:../../code/lib/channel-postmessage",
"@storybook/channel-websocket": "portal:../../code/lib/channel-websocket",
"@storybook/channels": "portal:../../code/lib/channels",
"@storybook/cli": "portal:../../code/lib/cli",
"@storybook/client-api": "portal:../../code/deprecated/client-api",
Expand Down
3 changes: 0 additions & 3 deletions test-storybooks/standalone-preview/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,10 @@
"@storybook/addon-viewport": "portal:../../code/addons/viewport",
"@storybook/addons": "portal:../../code/deprecated/addons",
"@storybook/angular": "portal:../../code/frameworks/angular",
"@storybook/api": "portal:../../code/lib/api",
"@storybook/blocks": "portal:../../code/lib/blocks",
"@storybook/builder-manager": "portal:../../code/builders/builder-manager",
"@storybook/builder-vite": "portal:../../code/builders/builder-vite",
"@storybook/builder-webpack5": "portal:../../code/builders/builder-webpack5",
"@storybook/channel-postmessage": "portal:../../code/lib/channel-postmessage",
"@storybook/channel-websocket": "portal:../../code/lib/channel-websocket",
"@storybook/channels": "portal:../../code/lib/channels",
"@storybook/cli": "portal:../../code/lib/cli",
"@storybook/client-api": "portal:../../code/deprecated/client-api",
Expand Down