Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Add CLI options (debugWebpack, webpackStatsJson, and more) #24388

Merged
merged 1 commit into from Oct 5, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Oct 5, 2023

Closes #

What I did

Seems like the angular schema was missing a few options which did not match with Storybook's CLI:

debugWebpack
webpackStatsJson
previewUrl
loglevel

These are now added for proper compatibility.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  1. Run a sandbox for an angular template, e.g. yarn task --task sandbox --start-from auto --template angular-cli/default-ts
  2. Try the new flags on both build and dev

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

馃 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf added bug angular ci:merged Run the CI jobs that normally run when merged. labels Oct 5, 2023
webpackStatsJson
previewUrl
loglevel
@yannbf yannbf force-pushed the yann/add-missing-angular-options branch from 0fe5359 to 5184a7a Compare October 5, 2023 13:57
@yannbf yannbf merged commit 80951d3 into next Oct 5, 2023
61 of 71 checks passed
@yannbf yannbf deleted the yann/add-missing-angular-options branch October 5, 2023 16:08
@yannbf yannbf mentioned this pull request Oct 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug ci:merged Run the CI jobs that normally run when merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants