Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: Support v14.2 useParams functionality #26874

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Apr 18, 2024

Closes #26850

What I did

This PR implements the new structure included in Nextjs 14.2 regarding next/navigation useParams. It's non-breaking for next 13.5 (the lowest version we support) so we actually don't need to do aliasing. I tested thoroughly with sandboxes and portable stories in both Next 14 and 13.

I also moved some stories from the Nextjs JS sandbox to Nextjs TS sandbox instead, and updated the portable stories one.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf added bug patch:yes Bugfix & documentation PR that need to be picked to main branch nextjs ci:merged Run the CI jobs that normally run when merged. labels Apr 18, 2024
@yannbf yannbf self-assigned this Apr 18, 2024
Copy link

nx-cloud bot commented Apr 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fb24aef. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf merged commit 316779b into next Apr 18, 2024
63 of 74 checks passed
@yannbf yannbf deleted the yann/fix-nextjs-14.2-useparams branch April 18, 2024 11:28
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
21 tasks
yannbf added a commit that referenced this pull request Apr 19, 2024
…rams

Nextjs: Support next 14.2 useParams functionality
(cherry picked from commit 316779b)
@github-actions github-actions bot mentioned this pull request Apr 21, 2024
44 tasks
@shilman shilman changed the title Nextjs: Support next 14.2 useParams functionality Next.js: Support v14.2 useParams functionality Apr 21, 2024
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 22, 2024
@JReinhold JReinhold mentioned this pull request Apr 23, 2024
1 task
@RickyRoller
Copy link

Hi @yannbf! Any chance this could be back-ported to Storybook 7 as well since it is also an issue there?

@yannbf
Copy link
Member Author

yannbf commented May 15, 2024

Hey @RickyRoller we could try, but now that Storybook 8 is out (actually we just released 8.1), we are likely only patching security fixes back to Storybook 7. Could you try upgrading your project to Storybook 8? There are incredible new features in @storybook/nextjs that would make your life easier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:merged Run the CI jobs that normally run when merged. nextjs patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: useParams returns null in NextJS 14.2. Storybook 7 & 8
3 participants