Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Japanese translations #6536

Merged
merged 2 commits into from Jun 11, 2020
Merged

Conversation

donuzium
Copy link
Contributor

@donuzium donuzium commented Jun 3, 2020

Description of what you did:

Updated Japanese translation file in strapi-admin.

My test result

$ yarn test:front
...
Test Suites: 92 passed, 92 total
Tests:       470 passed, 470 total
Snapshots:   11 passed, 11 total
Time:        25.875s
Ran all test suites.
✨  Done in 29.32s.

Thank you for your great work!!

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #6536 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6536   +/-   ##
=======================================
  Coverage   19.85%   19.85%           
=======================================
  Files         857      857           
  Lines       12076    12076           
  Branches     1963     1963           
=======================================
  Hits         2398     2398           
  Misses       8093     8093           
  Partials     1585     1585           
Flag Coverage Δ
#front 14.66% <ø> (ø)
#unit 41.26% <100.00%> (ø)
Impacted Files Coverage Δ
...ntent-type-builder/controllers/validation/types.js 52.27% <ø> (ø)
...ages/strapi-plugin-content-manager/services/uid.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22fb6c...a6b5d05. Read the comment docs.

Signed-off-by: Shun Shimizu <shimizu@thedott.io>
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for your contribution

@soupette soupette added source: core:admin Source is core/admin package issue: enhancement Issue suggesting an enhancement to an existing feature labels Jun 8, 2020
@soupette soupette added this to the 3.0.2 milestone Jun 8, 2020
@alexandrebodin alexandrebodin merged commit c2243af into strapi:master Jun 11, 2020
iicdii pushed a commit to iicdii/strapi that referenced this pull request Jul 2, 2020
Signed-off-by: Shun Shimizu <shimizu@thedott.io>
Signed-off-by: harimkims <harimkims@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants