update doc + add localhost in confirmation links if url is not set #7054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convly
reviewed
Jul 17, 2020
petersg83
force-pushed
the
fix/usersAndPermsLocalAuth
branch
from
9fc601e
to
564b93b
Compare
Codecov Report
@@ Coverage Diff @@
## master #7054 +/- ##
==========================================
+ Coverage 20.05% 26.18% +6.13%
==========================================
Files 858 1130 +272
Lines 12049 15404 +3355
Branches 1951 2435 +484
==========================================
+ Hits 2416 4033 +1617
- Misses 8062 9556 +1494
- Partials 1571 1815 +244
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
alexandrebodin
requested changes
Jul 20, 2020
| @@ -643,7 +644,7 @@ module.exports = { | |||
| settings.message = await strapi.plugins['users-permissions'].services.userspermissions.template( | |||
| settings.message, | |||
| { | |||
| URL: `${strapi.config.server.url}/auth/email-confirmation`, | |||
| URL: `${getAbsoluteServerUrl(strapi.config)}/auth/email-confirmation`, // ICICI | |||
| ### Email validation | ||
|
|
||
| This action sends an email to the user with the link to confirm the user. | ||
| :::tip NOTE | ||
| In production, make sure the `url` config property is set. Otherwise the validation link will redirect to `localhost`. More info on the config [here](../concepts/configurations.html#server). |
There was a problem hiding this comment.
links should be pointing to .md files. vue-press generate the right urls on build
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
petersg83
force-pushed
the
fix/usersAndPermsLocalAuth
branch
from
7e040ee
to
75be868
Compare
Merged
alexandrebodin
added
issue: bug
This was referenced Jun 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6909
Description of what you did:
http://{host}:{port}instead of nothing ifstrapi.config.server.urlis not set