Upload path can be absolute #7280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Noël <petersg83@gmail.com>
alexandrebodin
requested changes
Jul 31, 2020
alexandrebodin
requested changes
Aug 3, 2020
| ); | ||
| const staticDir = resolve(configPublicPath); |
There was a problem hiding this comment.
you need to call resolve(strapi.dir, publicPath) or this will not work with relative path
Codecov Report
@@ Coverage Diff @@
## master #7280 +/- ##
=======================================
Coverage 26.17% 26.17%
=======================================
Files 1130 1130
Lines 15413 15415 +2
Branches 2439 2439
=======================================
+ Hits 4034 4035 +1
- Misses 9560 9561 +1
Partials 1819 1819
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Pierre Noël <petersg83@gmail.com>
petersg83
force-pushed
the
fix/uploadPathAbsolute
branch
from
37ea533
to
bc96123
Compare
alexandrebodin
added
source: core:upload
ghost
mentioned this pull request
This was referenced Jun 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7257